77682[!!!][FEATURE] Always allow listeners to manipulate the canonical URL
Commit message
Review
-
Code review CR +2 Done
- Oli Bartsch +2
- Stefan Bürk +1
- Benni Mack +1
-
Verified V +2 Done
- Oli Bartsch +2
- Stefan Bürk +1
- Benni Mack +1
- core-ci +1 CI
Issues 1
Files 7
- typo3/sysext/core/Documentation/Changelog/13.0/Breaking-99807-RelocatedModifyUrlForCanonicalTagEvent.rstnew+51 −0
- typo3/sysext/core/Documentation/Changelog/13.0/Feature-99807-ImproveModifyUrlForCanonicalTagEvent.rstnew+36 −0
- typo3/sysext/seo/Classes/Canonical/CanonicalGenerator.php3+26 −22
- typo3/sysext/seo/Classes/Event/ModifyUrlForCanonicalTagEvent.php+9 −3
- typo3/sysext/seo/Classes/Exception/CanonicalGenerationDisabledException.phpnew+25 −0
- typo3/sysext/seo/Tests/Functional/Canonical/CanonicalGeneratorTest.php+7 −3
- typo3/sysext/seo/Tests/Unit/Event/ModifyUrlForCanonicalTagEventTest.php+30 −5
Review log 1319
-
Bastien Lutz uploaded patch set 1 02/03/23, 14:56
-
core-ci voted on patch set 1 V +1 02/03/23, 15:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/36991
-
Benni Mack commented on patch set 1 CR -1 02/03/23, 17:00
-
Bastien Lutz commented on patch set 1 02/04/23, 22:30
CanonicalGenerator.php:55ReplyGood point. How about renaming the existing event to something like setCanonicalTagUri and add a new event called modifyCanonicalTagUri after the generation of the canonical tag uri. This would solve the issue and allows to override it even if "no_index" is set. -
Benni Mack updated the commit message in patch set 2
CR -1V +105/03/23, 09:52 -
Benni Mack uploaded patch set 3 01/12/24, 15:07
-
Benni Mack commented on patch set 3 01/12/24, 15:12
moved the location, we now need a breaking RSTCanonicalGenerator.php:55ReplyDone -
core-ci voted on patch set 3 V -1 01/12/24, 15:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/51512
-
Oli Bartsch uploaded patch set 4
V -101/24/24, 14:24 -
core-ci voted on patch set 4 V -1 01/24/24, 14:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52083
-
Oli Bartsch uploaded patch set 5
V -101/24/24, 14:31 -
core-ci voted on patch set 5 V +1 01/24/24, 14:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52084
-
Oli Bartsch uploaded patch set 6
V +101/24/24, 15:52 -
core-ci voted on patch set 6 V -1 01/24/24, 16:00 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52094
-
core-ci voted on patch set 6 V +1 01/24/24, 16:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/52094
-
Benni Mack voted on patch set 6 CR +1 V +1 01/24/24, 16:41
-
Stefan Bürk voted on patch set 6 CR +1 V +1 01/24/24, 23:13
-
Oli Bartsch voted on patch set 6 CR +2 V +2 01/24/24, 23:21
-
Oli Bartsch merged patch set 7 01/24/24, 23:21
CanonicalGenerator.php:55