Review main Merged

77685[TASK] Use Locale object in Site Configuration

Benni Mack CR +2 V +2 Normal +63 −46 updated 02/04/23, 21:44

Commit message

This change introduces the combination of the newly
added Locale class and SiteLanguage, allowing to work
more with the objects than with strings as before.

We're also adding an internal "POSIX" formatted logic
to the Locale object, so the setLocale() calls can still
work as before.

This patch basically provides a bridge between
the previously used POSIX format ("de_AT.utf-8")
and the BCP-47 definition of language tags which is
the base for the Locale class. However, both formats
can now be used (in site configuration), and are properly
formatted in setLocale() or in HTTP response headers
in Frontend, which was a limitation before.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Jochen Roth +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 12

Review log 69

  1. Benni Mack uploaded patch set 1 02/03/23, 17:23

  2. core-ci voted on patch set 1 V -1 02/03/23, 17:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37005

  3. Benni Mack uploaded patch set 2 V -1 02/03/23, 20:19

  4. core-ci voted on patch set 2 V +1 02/03/23, 20:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37011

  5. Benni Mack updated the commit message in patch set 3 V +1 02/03/23, 20:33

  6. core-ci voted on patch set 3 V +1 02/03/23, 20:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37013

  7. Jochen Roth voted on patch set 3 V +1 CR +1 02/04/23, 21:30

  8. Georg Ringer voted on patch set 3 V +2 CR +2 02/04/23, 21:44

  9. Georg Ringer merged patch set 4 02/04/23, 21:44