Review main Merged

77691[BUGFIX] Fix appearance of FlexForm tab content

Nikita Hovratov CR +2 V +2 Easy +5 −14 updated 02/05/23, 19:43

Commit message

FlexForm was using the old Bootstrap "panel" classes for its sheet tab
content. Since the Bootstrap 5 update, the underlying "box-shadow" CSS
property became visible. This is now fixed by simply using the
"form-section" class like everywhere else for FormEngine container.

In addition, the negative margin hack for this specific case can now be
removed.

Note: The Tabs.html template is still used in the deprecated
ModuleTemplate->getDynamicTabMenu() method. As the markup has changed,
it could look a bit different compared to TYPO3 v11, in case custom CSS
was applied, which is very unlikely.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 912

  1. Nikita Hovratov uploaded patch set 1 02/04/23, 02:38

  2. Nikita Hovratov uploaded patch set 2 02/04/23, 02:41

  3. core-ci voted on patch set 1 V +1 02/04/23, 02:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37025

  4. core-ci voted on patch set 2 V +1 02/04/23, 02:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37026

  5. Jasmina Ließmann voted on patch set 2 V +1 CR +1 02/04/23, 15:44

  6. Christian Kuhn voted on patch set 2 V +1 CR +1 02/04/23, 18:16

  7. Nikita Hovratov commented on patch set 2 CR -1 02/04/23, 18:36

    do not merge yet.
  8. Nikita Hovratov updated the commit message in patch set 3 CR +1 V +1 02/04/23, 18:48

  9. core-ci voted on patch set 3 V +1 02/04/23, 18:56 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37061

  10. Stefan Bürk voted on patch set 3 V +1 CR +1 02/04/23, 20:41

  11. Georg Ringer voted on patch set 3 V +2 CR +2 02/05/23, 19:43

  12. Georg Ringer merged patch set 4 02/05/23, 19:43