77700[FEATURE] Additional parameters for shortcuts
Commit message
Review
-
Code review CR 0
-
Verified V -1
- core-ci -1 CI
Issues 1
Files 14
- typo3/sysext/backend/Classes/Controller/PageLayoutController.php2+2 −1
- typo3/sysext/core/Classes/Domain/Repository/PageRepository.php5+31 −7
- typo3/sysext/core/Configuration/TCA/pages.php+6 −10
- typo3/sysext/core/Documentation/Changelog/12.3/Feature-17406-AdditionalParametersForShortcuts.rst2new+35 −0
- typo3/sysext/core/ext_tables.sql4+1 −2
- typo3/sysext/frontend/Classes/Typolink/PageLinkBuilder.php5+6 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/Fixtures/TypoLinkScenario.yaml+4 −0
- typo3/sysext/frontend/Tests/Functional/SiteHandling/TypoLinkGeneratorTest.php2+52 −0
- typo3/sysext/frontend/Tests/Unit/ContentObject/Menu/AbstractMenuContentObjectTest.php+4 −1
- typo3/sysext/info/Tests/Functional/Controller/PageInformationControllerTest.php+4 −4
- typo3/sysext/install/Classes/Updates/ShortcutFieldMigration.php2new+98 −0
- typo3/sysext/install/Tests/Functional/Updates/Fixtures/ShortcutsPagesBase.csvnew+4 −0
- typo3/sysext/install/Tests/Functional/Updates/Fixtures/ShortcutsPagesMigrated.csvnew+4 −0
- typo3/sysext/install/Tests/Functional/Updates/ShortcutFieldMigrationTest.phpnew+49 −0
Review log 5172
Show 3347 earlier messages
-
Guido Schmechel uploaded patch set 1 02/04/23, 18:26
-
core-ci voted on patch set 1 V +1 02/04/23, 18:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37058
-
Guido Schmechel commented on patch set 1 CR -1 02/04/23, 19:03
From a UI point of view, it is better if we use the TCA type link. To clarify: Possibly a breaking change because the field int becomes string? -
Benni Mack commented on patch set 1 02/04/23, 19:33
how about we migrate the shortcut field itself to type=link? -
Guido Schmechel commented on patch set 1 02/04/23, 19:42
Reply
That's exactly what I'm changing :-) The other was rather uncool from Editor's point of view. -
Benni Mack commented on patch set 1 02/04/23, 20:04
Reply
ha, OK. did not see your latest comment there yet. thanks! -
Stefan Bürk commented on patch set 1 02/04/23, 20:24
Reply
Maybe I'm not fully seeing the use-case. But if the field itself is switched to "type=link" as Benni mentioned - wouldn't that adding two additional columns (shortcut_parameters & shortcut_fragment) not obsolete/superflous ? Additional arguments (parameters) can be added/entered in the page-linkbrowser shown by the field type link, also content elements are selectable creating fragment based on the content element uid oO -
Stefan Bürk commented on patch set 1 02/04/23, 20:33
Reply
switching to type=link, we should add aupdate wizard replacing "0" with "" in that field and eventually to t3 syntax, "also" not needed as integer is taken as pure page. -
Guido Schmechel uploaded patch set 2
CR -1V +102/04/23, 20:56 -
Guido Schmechel uploaded patch set 3 02/04/23, 20:58
-
core-ci voted on patch set 3 V -1 02/04/23, 21:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37070
-
core-ci voted on patch set 2 V -1 02/04/23, 21:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37069
-
Guido Schmechel uploaded patch set 4
V -102/04/23, 22:36 -
core-ci voted on patch set 4 V -1 02/04/23, 23:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37082
-
Guido Schmechel uploaded patch set 5
V -102/05/23, 08:21 -
Guido Schmechel uploaded patch set 6 02/05/23, 09:25
-
core-ci voted on patch set 5 V -1 02/05/23, 09:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37100
-
core-ci voted on patch set 6 V -1 02/05/23, 10:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37101
-
Guido Schmechel uploaded patch set 7
V -102/05/23, 11:10 -
Guido Schmechel uploaded patch set 8 02/05/23, 11:34
-
core-ci voted on patch set 7 V -1 02/05/23, 11:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37103
-
core-ci voted on patch set 8 V -1 02/05/23, 12:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37104
-
Guido Schmechel uploaded patch set 9
V -102/05/23, 16:28 -
core-ci voted on patch set 9 V +1 02/05/23, 16:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37119
-
Georg Ringer commented on patch set 9 02/05/23, 19:41
PageRepository.php:157use typed propertiesext_tables.sql:78can this be a breaking change as previously ext authors have been sure this is an integer? -
Stefan Bürk commented on patch set 9 02/05/23, 19:51
ext_tables.sql:78Replybasically - yes. -
Guido Schmechel commented on patch set 9 02/05/23, 21:41
PageRepository.php:157ReplyShould I change the other variables of the class here as well? These are not yet inside as TypedProperty. But this would not be part of the patch.ext_tables.sql:78ReplyHow do we deal with it? Once adding a Breaking RST and then set this feature only for v13 or is v12 still feasible? -
Benni Mack commented on patch set 9 02/06/23, 07:59
glad you added this, I had the beginning of this change in my stash for a few years already :) But never finished it.ext_tables.sql:78ReplyI think we need an upgrade wizard, IMHO this should not justify a Breaking change. -
Chris Müller uploaded patch set 10
V +102/08/23, 17:45 -
core-ci voted on patch set 10 V +1 02/08/23, 18:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37396
-
Guido Schmechel uploaded patch set 11
V +102/11/23, 11:53 -
core-ci voted on patch set 11 V +1 02/11/23, 12:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37605
-
Guido Schmechel commented on patch set 11 02/11/23, 12:07
Reply
Upgrade Wizard is now available.PageRepository.php:157ReplyDone, but only for the two new variables. -
Andreas Kienast commented on patch set 11 02/15/23, 11:14
PageLayoutController.php:344Since `$shortcutData` is only used in this `case`, I'd opt to move the call to `resolveShortcutLinkParts()` here. What do you think? -
Oli Bartsch commented on patch set 11 02/15/23, 13:04
Feature-17406-AdditionalParametersForShortcuts.rst:14Please mention that we are talking about the pages' shortcut field.ShortcutFieldMigration.php:61Could we use getPreparedQueryBuilder() instead? -
Guido Schmechel uploaded patch set 12
V +102/15/23, 20:50 -
core-ci voted on patch set 12 V +1 02/15/23, 20:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37780
-
Guido Schmechel commented on patch set 12 02/15/23, 21:57
PageLayoutController.php:344ReplyYou are right. In the other cases, this is not needed after all.Feature-17406-AdditionalParametersForShortcuts.rst:14ReplyThe various text passages have been adjusted and made equal.ShortcutFieldMigration.php:61ReplyYes, has been changed. -
Benni Mack commented on patch set 12 03/20/23, 15:26
PageLinkBuilder.php:377so this would mean we would override existing fragments? -
Guido Schmechel commented on patch set 12 03/20/23, 20:21
PageLinkBuilder.php:377ReplyThat is the question of what has more priority? - Page A, Page B and Page C are created. - I am on page A and have a link to page B, which is linked to content 123. - Status: Page A shows the link to page B with fragment 123 - Editor now decides to create page B as a shortcut to page C, but wants to jump to Content 456. - Status now: Page A now shows the shortcut to page C with fragment 456. -
Benni Mack commented on patch set 12 03/22/23, 19:26
PageLinkBuilder.php:377ReplyUsually when coming from typolink.section = #abcdef this should have priority (in my opinion), imagine you link to a content element within a different page? Anyway, I'll leave that up to you, the most important thing is that you a) document the behaviour you expect and b) we have tests for that behavior. -
Guido Schmechel commented on patch set 12 CR -1 03/23/23, 09:14
PageLinkBuilder.php:377ReplyOkay I understand your point better now. You are assuming that someone is already linking to the shortcut and then wants to dynamically change the section. I would still prioritize here on the field in the shortcut to have only one single point of truth. Otherwise you can also link directly to the target page and not to the shortcut, if you want to control it differently. I'll take care of it. -
Guido Schmechel uploaded patch set 13
CR -1V +103/24/23, 20:52 -
core-ci voted on patch set 13 V -1 03/24/23, 21:23 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39600
-
Guido Schmechel uploaded patch set 14
V -103/24/23, 21:59 -
core-ci voted on patch set 14 V -1 03/24/23, 22:48 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39611
-
Stefan Bürk rebased onto patch set 15
V -103/25/23, 11:47
-
core-ci voted on patch set 15 V +1 03/25/23, 11:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39627
-
Guido Schmechel commented on patch set 15 03/25/23, 12:00
PageLinkBuilder.php:377ReplyDone. Tests and an example in the documentation have been added. -
Andreas Kienast commented on patch set 15 03/27/23, 08:32
PageRepository.php:2231IMO this method doesn't belong into a repositoryTypoScriptFrontendController.php:1856I do not fully understand why we need this, hiding behind a flag looks fishy to me. Could you please elaborate?TypoLinkGeneratorTest.php:637public static with phpunit v10. -
Guido Schmechel commented on patch set 15 03/27/23, 10:21
PageRepository.php:2231Reply UnresolvedYeah, Benni didn't think that was so cool either. I'm a little lacking in creativity as to where the whole thing belongs, because ultimately two services are used again. Do you have any idea what might be more appropriate? Alternatively, we add a new service with a public method? We use the function in the PageLayoutController, too.TypoScriptFrontendController.php:1856ReplyThis function is used twice. Once the mountpoint is in play and this must continue to use $this->page. Therefore the distinction with a boolean to be able to control this.TypoLinkGeneratorTest.php:637ReplyAck -
Guido Schmechel uploaded patch set 16
V +103/27/23, 14:04 -
core-ci voted on patch set 16 V +1 03/27/23, 14:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39702
-
Benni Mack commented on patch set 16 CR -1 03/27/23, 19:56
as much as I would love to have this feature in, I think we have a further issue with this patch. Recursive shortcuts don't get resolved as getShortcutPage() needs the adaption... it cannot handle the value when calling itself. -
Guido Schmechel commented on patch set 16 03/27/23, 20:24
Reply
I see. Let's rather integrate stable features. It will not be the last TYPO3 version ;-) -
Lina Wolf commented on patch set 16 07/04/23, 16:24
I talked about this use case with Anja a while ago. It seems to be a good idea to introduce a new page type with the typolink shortcut, which also uses a new field in the pages table. We can then deprecate the existing page types shortcut and external reference and have a smooth migration. -
Jan Kornblum commented on patch set 16 07/16/24, 11:12
Reply
I like the idea with the new page type, it would also solve #102129, and as Lina says, offers a nice migration path. -
Benni Mack commented on patch set 16 01/08/25, 16:37
-
Benni Mack marked it work in progress 03/28/25, 13:30
-
Benni Mack uploaded patch set 17
CR -1V +109/23/25, 08:20 -
Benni Mack uploaded patch set 18 09/23/25, 08:21
-
core-ci voted on patch set 17 V -1 09/23/25, 08:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85371
-
core-ci voted on patch set 18 V -1 09/23/25, 08:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/85372
-
Lina Wolf commented on patch set 18 10/27/25, 10:15
Starting work on this -
Lina Wolf uploaded patch set 19
V -110/27/25, 13:01 -
core-ci voted on patch set 19 V -1 10/27/25, 13:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87655
-
Lina Wolf uploaded patch set 20
V -110/27/25, 14:22 -
core-ci voted on patch set 20 V +1 10/27/25, 14:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87665
-
Lina Wolf commented on patch set 20 10/27/25, 14:32
TypoScriptFrontendController.php:1856ReplyDone -
Lina Wolf uploaded patch set 21
V +110/27/25, 15:30 -
core-ci voted on patch set 21 V -1 10/27/25, 15:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/87671
-
Benni Mack abandoned the change 12/09/25, 09:40
Abandoning this change, thanks Guido for this work, the feature got moved into Core 14 in a different way now.