Review main Merged

77701[TASK] Replace icon in position map elements

Torben Hansen CR +2 V +2 Easy +7 −7 updated 02/05/23, 19:44

Commit message

The current arrow icon in position map elements is very small
and may be hard to identify as an arrow.

This patch replaces the icon with a better version of an
arrow icon.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 67

  1. Torben Hansen uploaded patch set 1 02/04/23, 18:32

  2. core-ci voted on patch set 1 V +1 02/04/23, 18:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37060

  3. Stefan Bürk commented on patch set 1 02/04/23, 21:17

    I'm too stupid - how the heck do I get these "arrow" markers at all ? I looked into the issue, which mention "When inserting a new page or re-positioning a page or content element". What does this really mean ? If I ... * select a page/sysfolder/... from above the page tree (which i can only drag&drop) I only get a blue line indicating where to insert it * moving a page (drag&drop) the same blue line * if I select "copy" from the context of a page, I still get nothing (can only select over context mene to paste it after or in) What am I doing wrong ? Please enlight me 🙏
  4. Stefan Bürk commented on patch set 1 02/04/23, 21:24

    Personally I could not see that much difference. But I can get the reason from the commit message, and think that it "may be" a issue for some. So vote for me now. I guess someone from the UX team may have a look, if this fit's into their plan.

    Reply

    Found it 😎
  5. Stefan Bürk voted on patch set 1 V +1 CR +1 02/04/23, 21:25

  6. Georg Ringer voted on patch set 1 V +2 CR +2 02/05/23, 19:44

  7. Georg Ringer merged patch set 2 02/05/23, 19:44