Review main Merged

77704[TASK] Update various low-level PHP dependencies

Benni Mack CR +2 V +2 Normal +99 −118 updated 02/04/23, 23:08

Commit message

Various dependencies which have released
major versions (to be compatible to further
upstream packages) are now raised:

* doctrine/annotations (allowing both 1.13 + 2)
* doctrine/event-manager (For DBAL v4 compatibility)
* doctrine/lexer (v2 + v3 instead of v1)
* egulias/email-validator (4.0) using lexer

Core `TYPO3\CMS\Core\Database\Schema\Parser\Parser`
has got proper native types and return types to
match deprecated array access on tokens returned
by raised `doctrine/lexer` - which is used internal.
That solved some phpstan ignore patterns as side-change.

Used commands:
* composer req "doctrine/annotations:^1.13.3 || ^2.0" "doctrine/event-manager:^2.0" "doctrine/lexer:^2.0 || ^3.0" "egulias/email-validator:^4.0" -W
* composer req "doctrine/annotations:^1.13.3 || ^2.0" "doctrine/event-manager:^2.0" "doctrine/lexer:^2.0 || ^3.0" "egulias/email-validator:^4.0" -W -d typo3/sysext/core --no-update
* Build/Scripts/runTests.sh -s phpstanGenerateBaseline

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 5