Review main Merged

77711[TASK] sysext/install/Check: check PHP extension "tokenizer"

TYPO3com CR +2 V +2 Easy +5 −1 updated 02/06/23, 16:17

Commit message

Various libraries incorporated by TYPO3 use the "token_get_all"
function, crashing PHP execution if the "tokenizer" extension is not
loaded.

The system environment pre-check now checks the presence of the PHP
extension. Also, Composer now requires the presence of the
`ext-tokenizer` module.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oliver Klee +1
    • Markus Klein +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Markus Klein +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 2027

Show 12 earlier messages
  1. TYPO3com uploaded patch set 1 02/06/23, 12:14

  2. Oliver Hader voted on patch set 1 CR +1 02/06/23, 12:16

  1. core-ci voted on patch set 1 V +1 02/06/23, 12:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37156

  2. Markus Klein updated the commit message in patch set 2 CR +1 V +1 02/06/23, 12:26

  3. Markus Klein voted on patch set 2 CR +1 02/06/23, 12:31

  4. Oliver Hader voted on patch set 2 CR +1 02/06/23, 12:38

  5. Oliver Klee voted on patch set 2 CR +1 02/06/23, 12:51

  6. Benni Mack commented on patch set 2 CR +1 02/06/23, 12:57

    Max, thanks for your contribution. Do we also need to require "ext-tokenzier" in composer.json?
  7. core-ci voted on patch set 2 V +1 02/06/23, 12:57 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37158

  8. Christian Kuhn commented on patch set 2 CR -1 02/06/23, 13:04

    Reply

    yes, please. tokenizer is an "enabled by default" extension, so this affects only (rather seldom / special cases) self-built php consumers with explicit --disable-tokenizer at configure time. nevertheless, we should add it to /typo3/sysext/core/composer.json and /composer.json. should be easy to do, -1 for now. could take care later if nobody is quicker and we may want to have a look at docs as well.
  9. Andreas Kienast uploaded patch set 3 CR +1 V +1 02/06/23, 14:00

  10. Andreas Kienast uploaded patch set 4 02/06/23, 14:02

  11. Andreas Kienast uploaded patch set 5 02/06/23, 14:03

  12. Andreas Kienast voted on patch set 5 V +1 CR +1 02/06/23, 14:03

  13. Wouter Wolters commented on patch set 5 02/06/23, 14:10

    Small spelling issue
    now checks the
  14. core-ci voted on patch set 4 V +1 02/06/23, 14:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37166

  15. core-ci voted on patch set 5 V +1 02/06/23, 14:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37167

  16. Andreas Kienast updated the commit message in patch set 6 CR +1 V +1 02/06/23, 14:17

  17. Oliver Klee voted on patch set 6 CR +1 02/06/23, 14:21

  18. core-ci voted on patch set 3 V +1 02/06/23, 14:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37165

  19. core-ci voted on patch set 6 V +1 02/06/23, 14:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37169

  20. Markus Klein voted on patch set 6 V +1 CR +1 02/06/23, 14:56

  21. Benni Mack commented on patch set 6 V +1 CR +1 02/06/23, 15:03

    Reply

    Done

    Reply

    Done
  22. Christian Kuhn voted on patch set 6 V +1 CR +1 02/06/23, 15:19

  23. Christian Kuhn commented on patch set 6 V +2 CR +2 02/06/23, 16:07

  24. Christian Kuhn merged patch set 7 02/06/23, 16:07

  25. Christian Kuhn commented on patch set 7 02/06/23, 16:17

    Check.php:46 Unresolved

    ... awesome how outdated this comment is meanwhile and how often the entire point of this comment has been violated with patches after some years now: I'm now counting 5 direct core dependencies according to the use statements. we may want to reconsider or at least rephrase.