Review main Merged

77713[TASK] Streamline labels in Install Tool buttons

Andreas Kienast CR +2 V +2 Normal +49 −49 updated 07/17/23, 15:31

Commit message

The button labels in the Install Tool are now using ellipsis
to indicate that clicking a button will invoke another "confirmable" action before really executing the desired function.

This is a common practice in UI design.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oliver Klee +1
    • Torben Hansen +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Torben Hansen +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 1923

  1. Andreas Kienast uploaded patch set 1 02/06/23, 15:13

  2. core-ci voted on patch set 1 V +1 02/06/23, 15:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37175

  3. Oliver Klee commented on patch set 1 02/06/23, 15:25

    EnvironmentCest.php:40

    Should those in general be three separate dots ("...") or the ellipsis character ("…", which cannot be broken into multiple lines)?
  4. Andreas Kienast commented on patch set 1 CR -1 02/06/23, 16:43

    Going to use real ellipsis characters

    EnvironmentCest.php:40 Reply

    Good catch
  5. Andreas Kienast uploaded patch set 2 CR -1 V +1 02/06/23, 16:57

  6. core-ci voted on patch set 2 V +1 02/06/23, 17:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37188

  7. Benni Mack commented on patch set 2 02/06/23, 17:37

    Cards.html:12

    can you remove the additional space? also there is another additional space after "data-inline="1" which is superfluous?

    Cards.html:47

    same here

    Cards.html:76

    same here
  8. Andreas Kienast uploaded patch set 3 V +1 02/06/23, 17:42

  9. Andreas Kienast commented on patch set 3 02/06/23, 17:47

    Cards.html:12 Reply

    Done

    Cards.html:47 Reply

    Done

    Cards.html:76 Reply

    Done
  10. core-ci voted on patch set 3 V +1 02/06/23, 18:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37198

  11. Oliver Klee commented on patch set 3 02/06/23, 18:12

    Cards.html:48

    We could also use the … character without encoding it as a HTML entity (as it's a regular UTF-8 characters). This will make the HTML a bit easier to read.
  12. Oliver Klee commented on patch set 3 02/06/23, 18:13

    EnvironmentCest.php:40 Reply

    Done
  13. Andreas Kienast commented on patch set 3 02/06/23, 19:28

    Cards.html:48 Reply

    Wouldn't do this for now, existing markup also uses the entity.
  14. Robert Kärner commented on patch set 3 02/08/23, 10:00

    My personal opinion on this: Good, but should be added only when additional user input is required or a confirmation is shown. Taking the Environment menu for example, "Show System Information" immediately shows the system information after clicking the button, same as "View PHP Info". Also, "Check Environment", "Check Directory Status" and "Test Images" immediately execute and scan the system or run image tests. Only "Test Mail Setup" won't execute immediately, as the email address prompt is shown before. I've sticked to the Microsoft UX guideline in the past, stating that "Ellipsis indicate that a command needs additional information. Don't use an ellipsis whenever an action displays another window — only when additional information is required." I also saw that the Mac UX guideline state the opposite, so I won't vote on this patch and only share my feedback.
  15. Andreas Kienast commented on patch set 3 02/08/23, 10:48

    Reply

    Thank you for your input. It seems I unintentionally stick to the Mac UX guideline, but it's good to see that there are several approached. I think it makes sense to stick to one guideline and also communicate/document this. I'll reach this to the UX team for further discussion.
  16. Oli Bartsch updated the commit message in patch set 4 V +1 02/08/23, 12:10

  17. core-ci voted on patch set 4 V +1 02/08/23, 12:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37356

  18. Oliver Klee commented on patch set 4 07/12/23, 15:36

    Cards.html:48 Reply

    Ack
  19. Oliver Klee voted on patch set 4 CR +1 07/12/23, 15:36

  20. Torben Hansen voted on patch set 4 V +1 CR +1 07/16/23, 10:02

  21. Christian Kuhn voted on patch set 4 V +1 CR +1 07/17/23, 11:17

  22. Andreas Kienast voted on patch set 4 V +2 CR +2 07/17/23, 15:31

  23. Andreas Kienast merged patch set 5 07/17/23, 15:31