Review main Merged

77715[TASK] Update sysext/install/Check class comment

Christian Kuhn CR +2 V +2 Easy +5 −17 updated 02/06/23, 17:19

Commit message

With the first rewrite of the install tool in
2013, Check.php came with a class comment the
class shouldn't have *any* dependencies at all.

It of course didn't take long until this was
violated. Ten years later, the comment is totally
outdated and adapted with the patch a bit to be
less awkward.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 56

  1. Christian Kuhn uploaded patch set 1 02/06/23, 16:27

  2. Stefan Bürk voted on patch set 1 V +1 CR +1 02/06/23, 16:32

  3. core-ci voted on patch set 1 V +1 02/06/23, 16:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37182

  4. Benni Mack voted on patch set 1 V +1 CR +1 02/06/23, 17:11

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 02/06/23, 17:19

  6. Christian Kuhn merged patch set 2 02/06/23, 17:19