Review main Merged

77719[BUGFIX] Support deferred ConsumerScope in GlobalEventHandler

Nicole Hummel CR +2 V +2 Easy +20 −17 updated 07/10/23, 20:59

Commit message

The GlobalEventHandler changes the location of the current (target)
window. The location is set to a given destination without any ability
to interrupt. The existing ConsumerScope API isn't used even if the
current window is the ContentContainer. This patch extends the handling
of a navigation action by checking its target window and using proper
ContentContainer API to set the location. Therefore registered listener
can deny a location change and trigger own functions.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 2

Review log 1929

Show 24 earlier messages
  1. Nicole Hummel uploaded patch set 1 02/06/23, 17:37

  2. core-ci voted on patch set 1 V -1 02/06/23, 18:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37195

  3. Nicole Hummel uploaded patch set 2 V -1 02/06/23, 18:13

  4. core-ci voted on patch set 2 V -1 02/06/23, 18:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37202

  1. Nicole Hummel uploaded patch set 3 V -1 02/06/23, 18:35

  2. Nicole Hummel uploaded patch set 4 02/06/23, 18:45

  3. core-ci voted on patch set 3 V -1 02/06/23, 18:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37204

  4. core-ci voted on patch set 4 V -1 02/06/23, 19:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37207

  5. Helmut Hummel uploaded patch set 5 V -1 02/28/23, 16:47

  6. core-ci voted on patch set 5 V +1 02/28/23, 17:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38218

  7. Helmut Hummel voted on patch set 5 V +1 CR +1 02/28/23, 23:13

  8. Christian Kuhn commented on patch set 5 03/01/23, 12:54

    this looks as if it has been pushed a second time with https://review.typo3.org/c/Packages/TYPO3.CMS/+/77723 ?
  9. Helmut Hummel commented on patch set 5 03/01/23, 13:49

    Reply

    abandoned the wrong one
  10. Benni Mack updated the commit message in patch set 6 CR +1 V +1 05/03/23, 09:30

  11. Oliver Hader rebased onto patch set 7 05/03/23, 11:53

  12. core-ci voted on patch set 7 V -1 05/03/23, 12:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41517

  13. Stefan Bürk rebased onto patch set 8 V -1 06/20/23, 01:36

  14. core-ci voted on patch set 8 V -1 06/20/23, 01:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42816

  15. Andreas Kienast uploaded patch set 9 V -1 07/07/23, 08:44

  16. Andreas Kienast updated the commit message in patch set 10 07/07/23, 08:44

  17. core-ci voted on patch set 10 V -1 07/07/23, 08:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43872

  18. core-ci commented on patch set 10 07/07/23, 09:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43872

  19. Benjamin Franzke commented on patch set 10 07/07/23, 09:38

    CI Tests fail because of an incotrect sudo-mode redirect, in non-secure environments (non-https/localhost domain), so that Viewport can not be used, as the extensionmanager is executed on the main frame instead of the list_frame. I will take care.
  20. Benjamin Franzke rebased onto patch set 11 V -1 07/07/23, 19:40

  21. core-ci voted on patch set 11 V +1 07/07/23, 19:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43925

  22. Benjamin Franzke commented on patch set 11 V +1 CR +1 07/07/23, 19:57

    The tests are fixed now, by adapting sudo-mode to load ExtensionManager with the full backend frame in the non-secure (HTTP) test setup. The respecitve relation chains needs to be merged first, still this patch then is fine by me.
  23. Stefan Bürk voted on patch set 11 V +1 CR +1 07/10/23, 20:37

  24. Benjamin Franzke voted on patch set 11 V +2 CR +2 07/10/23, 20:59

  25. Benjamin Franzke merged patch set 12 07/10/23, 20:59