77719[BUGFIX] Support deferred ConsumerScope in GlobalEventHandler
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Stefan Bürk +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Stefan Bürk +1
- core-ci +1 CI
Issues 2
Files 2
Review log 1929
Show 24 earlier messages
-
Nicole Hummel uploaded patch set 1 02/06/23, 17:37
-
core-ci voted on patch set 1 V -1 02/06/23, 18:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37195
-
Nicole Hummel uploaded patch set 2
V -102/06/23, 18:13 -
core-ci voted on patch set 2 V -1 02/06/23, 18:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37202
-
Nicole Hummel uploaded patch set 3
V -102/06/23, 18:35 -
Nicole Hummel uploaded patch set 4 02/06/23, 18:45
-
core-ci voted on patch set 3 V -1 02/06/23, 18:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37204
-
core-ci voted on patch set 4 V -1 02/06/23, 19:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37207
-
Helmut Hummel uploaded patch set 5
V -102/28/23, 16:47 -
core-ci voted on patch set 5 V +1 02/28/23, 17:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38218
-
Helmut Hummel voted on patch set 5 V +1 CR +1 02/28/23, 23:13
-
Christian Kuhn commented on patch set 5 03/01/23, 12:54
this looks as if it has been pushed a second time with https://review.typo3.org/c/Packages/TYPO3.CMS/+/77723 ? -
Helmut Hummel commented on patch set 5 03/01/23, 13:49
Reply
abandoned the wrong one -
Benni Mack updated the commit message in patch set 6
CR +1V +105/03/23, 09:30 -
Oliver Hader rebased onto patch set 7 05/03/23, 11:53
-
core-ci voted on patch set 7 V -1 05/03/23, 12:31 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/41517
-
Stefan Bürk rebased onto patch set 8
V -106/20/23, 01:36 -
core-ci voted on patch set 8 V -1 06/20/23, 01:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/42816
-
Andreas Kienast uploaded patch set 9
V -107/07/23, 08:44 -
Andreas Kienast updated the commit message in patch set 10 07/07/23, 08:44
-
core-ci voted on patch set 10 V -1 07/07/23, 08:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43872
-
core-ci commented on patch set 10 07/07/23, 09:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43872
-
Benjamin Franzke commented on patch set 10 07/07/23, 09:38
CI Tests fail because of an incotrect sudo-mode redirect, in non-secure environments (non-https/localhost domain), so that Viewport can not be used, as the extensionmanager is executed on the main frame instead of the list_frame. I will take care. -
Benjamin Franzke rebased onto patch set 11
V -107/07/23, 19:40 -
core-ci voted on patch set 11 V +1 07/07/23, 19:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43925
-
Benjamin Franzke commented on patch set 11 V +1 CR +1 07/07/23, 19:57
The tests are fixed now, by adapting sudo-mode to load ExtensionManager with the full backend frame in the non-secure (HTTP) test setup. The respecitve relation chains needs to be merged first, still this patch then is fine by me. -
Stefan Bürk voted on patch set 11 V +1 CR +1 07/10/23, 20:37
-
Benjamin Franzke voted on patch set 11 V +2 CR +2 07/10/23, 20:59
-
Benjamin Franzke merged patch set 12 07/10/23, 20:59