Review main Merged

77721[TASK] Update display of system information dropdown

Jasmina Ließmann CR +2 V +2 Easy +15 −14 updated 02/09/23, 19:27

Commit message

The heading in the dropdown content now matches the label already
shown as button to open the dropdown in small viewports.

With #99742 a heading was introduced to structure the messages listed
below. With this change this heading will be removed again.

In addition, the standard link markup is now also used in the
introductory text.

The badge contains the amount of error messages. Badge position is now
aligned horizontally in the middle of the row in small viewports.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 3

Files 6

Review log 1014

  1. Jasmina Ließmann uploaded patch set 1 02/06/23, 19:13

  2. Jasmina Ließmann commented on patch set 1 02/06/23, 19:19

    The position of the badge on mobile/tablet viewports now looks good on my operating system (Windows). Maybe MacOS and Linux users could verify this?
  3. core-ci voted on patch set 1 V +1 02/06/23, 19:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37209

  4. Annett Jähnichen commented on patch set 1 V +1 02/06/23, 20:44

    Tested on a Mac with Safari Version 16.2 (18614.3.7.1.5) responsive mobile and tablet resolution Chrome Version 109.0.5414.119 (Offizieller Build) (x86_64) responsive mobile and tablet resolution
  5. Jasmina Ließmann commented on patch set 1 02/06/23, 20:59

    Reply

    Thanks! :)
  6. Jasmina Ließmann uploaded patch set 2 V +1 02/08/23, 17:57

  7. core-ci voted on patch set 2 V +1 02/08/23, 18:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37403

  8. Jasmina Ließmann uploaded patch set 3 V +1 02/09/23, 18:41

  9. Jasmina Ließmann updated the commit message in patch set 4 02/09/23, 18:41

  10. core-ci voted on patch set 4 V +1 02/09/23, 18:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37491

  11. core-ci voted on patch set 3 V +1 02/09/23, 19:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37490

  12. Christian Kuhn voted on patch set 4 V +1 CR +1 02/09/23, 19:25

  13. Stefan Bürk voted on patch set 4 V +2 CR +2 02/09/23, 19:27

  14. Stefan Bürk merged patch set 5 02/09/23, 19:27