Review main Merged

77722[TASK] Add badge for disabled task group

Jochen Roth CR +2 V +2 Easy +16 −3 updated 02/10/23, 10:02

Commit message

Currently there is no indication for a user
to see if a task group is disabled/hidden.

This has been changed by adding a badge for
disabled/hidden groups and also another badge
for tasks belonging to a disabled group.
The "late" badge and "next excecution" are now
hidden as well.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Benni Mack +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1218

  1. Jochen Roth uploaded patch set 1 02/06/23, 19:24

  2. Jochen Roth uploaded patch set 2 02/06/23, 19:28

  3. core-ci voted on patch set 1 V +1 02/06/23, 19:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37210

  4. Jochen Roth uploaded patch set 3 02/06/23, 19:33

  5. core-ci voted on patch set 2 V +1 02/06/23, 19:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37211

  6. core-ci voted on patch set 3 V +1 02/06/23, 19:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37212

  7. Georg Ringer commented on patch set 3 02/06/23, 22:54

    also for 11?

    locallang.xlf:396

    can we get some camel case here?
  8. Jochen Roth uploaded patch set 4 V +1 02/08/23, 14:22

  9. Jochen Roth commented on patch set 4 02/08/23, 14:23

    Reply

    Yes, makes sense. Added 11.5

    locallang.xlf:396 Reply

    Done
  10. core-ci voted on patch set 4 V +1 02/08/23, 14:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37378

  11. Christian Kuhn commented on patch set 4 02/10/23, 09:29

    Reply

    with the rewrite of the scheduler controller in v12, this gives quite some headaches in the backport. since the issue is not critical, i prefer to not backport it.
  12. Christian Kuhn updated the commit message in patch set 5 V +1 02/10/23, 09:30

  13. Christian Kuhn rebased onto patch set 6 02/10/23, 09:30

  14. Christian Kuhn voted on patch set 6 V +1 CR +1 02/10/23, 09:30

  15. core-ci voted on patch set 5 V +1 02/10/23, 09:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37535

  16. core-ci voted on patch set 6 V +1 02/10/23, 09:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37536

  17. Benni Mack voted on patch set 6 V +2 CR +2 02/10/23, 10:02

  18. Benni Mack merged patch set 7 02/10/23, 10:02