Review main Abandoned

77723[BUGFIX] Support deferred ConsumerScope in GlobalEventHandler

Helmut Hummel CR 0 V 0 Easy +27 −16 updated 03/01/23, 13:49

Commit message

The GlobalEventHandler changes the location of the current (target)
window. The location is set to a given destination without any ability
to interrupt. The existing ConsumerScope API isn't used even if the
current window is the ContentContainer. This patch extends the handling
of a navigation action by checking its target window and using proper
ContentContainer API to set the location. Therefore registered listener
can deny a location change and trigger own functions.
Resolves: #95474
Releases: main, 11.5
Change-Id: If6a3b1cc546e1f2ff0b8e9fed3f83055f3f55e49

Review

  • Code review CR 0
  • Verified V 0

Files 2

Review log 35

  1. Helmut Hummel uploaded patch set 1 02/06/23, 19:38

  2. core-ci voted on patch set 1 V +1 02/06/23, 19:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37213

  3. Helmut Hummel rebased onto patch set 2 V +1 02/27/23, 17:16

  4. core-ci voted on patch set 2 V +1 02/27/23, 17:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38164

  5. Helmut Hummel abandoned the change 03/01/23, 13:49

    wrong push