Review main Merged

77728[BUGFIX] Avoid disabling page caches when having cHash validation enforced

Oliver Hader CR +2 V +2 Easy +6 −1 updated 02/07/23, 07:45

Commit message

If $GLOBALS['TYPO3_CONF_VARS']['FE']['cacheHash']['enforceValidation']
is enabled and the HTTP request only contains the `?id` query parameter,
caching for the page is disabled - which should be avoided.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 911

  1. Oliver Hader uploaded patch set 1 02/06/23, 21:13

  2. Oli Bartsch voted on patch set 1 V +1 CR +1 02/06/23, 21:37

  3. core-ci voted on patch set 1 V +1 02/06/23, 21:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37227

  4. Oliver Hader rebased onto patch set 2 CR +1 V +1 02/06/23, 23:03

  5. core-ci voted on patch set 2 V +1 02/06/23, 23:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37238

  6. Oli Bartsch voted on patch set 2 V +2 CR +2 02/07/23, 06:11

  7. Oli Bartsch voted on patch set 2 V +1 CR +1 02/07/23, 06:11

  8. Stefan Bürk voted on patch set 2 V +2 CR +2 02/07/23, 07:12

  9. Stefan Bürk merged patch set 3 02/07/23, 07:12

  10. Benjamin Franzke commented on patch set 3 02/07/23, 07:20

    I don't really like that evaluatePageArgumentsWithoutCacheHash() is sideeffects at all (setting disableCache), but that's for sure another topic. For readability (I somehow had hard times to grasp what the code does, because I didn't figure that the early condition was used to prevent the $this->disableCache=true assignment) I'd like to change the ordering.
  11. Oliver Hader commented on patch set 3 02/07/23, 07:45

    Reply

    I totally agree - a lot can be refactored and restructured here. The application's decision and process flow needs to be more obvious...