77728[BUGFIX] Avoid disabling page caches when having cHash validation enforced
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Oli Bartsch +1
-
Verified V +2 Done
- Stefan Bürk +2
- Oli Bartsch +1
- core-ci +1 CI
Issues 1
Files 1
Review log 911
-
Oliver Hader uploaded patch set 1 02/06/23, 21:13
-
Oli Bartsch voted on patch set 1 V +1 CR +1 02/06/23, 21:37
-
core-ci voted on patch set 1 V +1 02/06/23, 21:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37227
-
Oliver Hader rebased onto patch set 2
CR +1V +102/06/23, 23:03 -
core-ci voted on patch set 2 V +1 02/06/23, 23:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37238
-
Oli Bartsch voted on patch set 2 V +2 CR +2 02/07/23, 06:11
-
Oli Bartsch voted on patch set 2 V +1 CR +1 02/07/23, 06:11
-
Stefan Bürk voted on patch set 2 V +2 CR +2 02/07/23, 07:12
-
Stefan Bürk merged patch set 3 02/07/23, 07:12
-
Benjamin Franzke commented on patch set 3 02/07/23, 07:20
I don't really like that evaluatePageArgumentsWithoutCacheHash() is sideeffects at all (setting disableCache), but that's for sure another topic. For readability (I somehow had hard times to grasp what the code does, because I didn't figure that the early condition was used to prevent the $this->disableCache=true assignment) I'd like to change the ordering. -
Oliver Hader commented on patch set 3 02/07/23, 07:45
Reply
I totally agree - a lot can be refactored and restructured here. The application's decision and process flow needs to be more obvious...