Review main Abandoned

77729[BUGFIX] Allow only one content type for clipboard action

Lukas Niestroj CR 0 V 0 Normal +92 −1 updated 06/25/24, 14:02

Commit message

Disable other multi-record selection tables on checkbox selection to
prevent the user from selecting more rows from different tables,
as this is technically not possible.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 3

Review log 2943

Show 1118 earlier messages
  1. Lukas Niestroj uploaded patch set 1 02/06/23, 21:41

  2. core-ci voted on patch set 1 V -1 02/06/23, 21:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37230

  3. Lukas Niestroj commented on patch set 1 02/07/23, 06:02

    I update the tests soon.
  4. Lukas Niestroj uploaded patch set 2 V -1 02/07/23, 07:28

  5. Chris Müller updated the commit message in patch set 3 02/07/23, 07:29

  6. core-ci voted on patch set 2 V -1 02/07/23, 07:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37248

  7. core-ci voted on patch set 3 V -1 02/07/23, 07:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37250

  8. Josef Glatz updated the commit message in patch set 4 V -1 02/07/23, 12:41

  9. Josef Glatz commented on patch set 4 V -1 02/07/23, 12:43

    if it's a feature it needs a rSt AND mostly only for main branch. If it's a task/bugfix 11.5 could be fixed also.
  10. core-ci voted on patch set 4 V -1 02/07/23, 13:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37288

  11. Lukas Niestroj uploaded patch set 5 V -1 02/07/23, 19:16

  12. Lukas Niestroj commented on patch set 5 02/07/23, 19:22

    Reply

    Hi Josef, I am not 100% sure whether to address this as a feature, since the change is an addition to the overall UX a user has. Currently adding records from different tables to the clipboards just moves one of a kind. The change disables "cross" selection to prevent irritating loses.
  13. core-ci voted on patch set 5 V -1 02/07/23, 19:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37310

  14. Lukas Niestroj uploaded patch set 6 V -1 02/07/23, 19:28

  15. core-ci voted on patch set 6 V +1 02/07/23, 19:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37312

  16. Josef Glatz updated the commit message in patch set 7 V +1 02/08/23, 06:53

  17. core-ci voted on patch set 7 V +1 02/08/23, 07:00 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37324

  18. Josef Glatz commented on patch set 7 CR -1 02/08/23, 07:37

    Please target only "main" if this patch is a feature. Also use the https://forger.typo3.com/utilities/rst to write a proper ChangeLog documentation
  1. Lukas Niestroj uploaded patch set 8 CR -1 V +1 02/08/23, 10:46

  2. core-ci voted on patch set 8 V +1 02/08/23, 11:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37354

  3. Lukas Niestroj commented on patch set 8 02/13/23, 20:08

    This patch is ready for review.
  4. Lukas Niestroj uploaded patch set 9 V +1 02/15/23, 07:53

  5. core-ci voted on patch set 9 V +1 02/15/23, 08:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37726

  6. Lukas Niestroj uploaded patch set 10 V +1 03/14/23, 13:42

  7. core-ci voted on patch set 10 V +1 03/14/23, 13:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38926

  8. Lukas Niestroj updated the commit message in patch set 11 V +1 03/27/23, 06:19

  9. core-ci voted on patch set 11 V +1 03/27/23, 06:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39662

  10. Lukas Niestroj commented on patch set 11 09/26/23, 06:37

    Reply

    Done
  11. Andreas Kienast commented on patch set 11 09/26/23, 06:59

    I wonder whether this really qualifies as a feature and not as a bugfix. If it remains a feature, please move the ReST file to the `13.0` directory.
  12. Josef Glatz commented on patch set 11 09/28/23, 04:36

    Reply

    i also tend more to a Bugfix plus adding 12 (+11) branches
  13. Simon Schaufelberger uploaded patch set 12 V +1 05/15/24, 23:31

  14. Simon Schaufelberger commented on patch set 12 CR +1 V +1 05/15/24, 23:32

    Reply

    Which branches should we target now?
  15. core-ci voted on patch set 12 V +1 05/15/24, 23:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57796

  16. Simon Schaufelberger uploaded patch set 13 CR +1 V +1 05/15/24, 23:40

  17. core-ci voted on patch set 13 V +1 05/15/24, 23:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57797

  18. Simon Schaufelberger voted on patch set 13 CR +1 V +1 05/16/24, 00:00

  19. Simon Schaufelberger uploaded patch set 14 CR +1 V +1 05/16/24, 10:11

  20. core-ci voted on patch set 14 V +1 05/16/24, 10:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/57828

  21. Lukas Niestroj voted on patch set 14 V +1 05/21/24, 05:15

  22. Simon Schaufelberger commented on patch set 14 05/21/24, 09:45

    Reply

    Done
  23. Benni Mack abandoned the change 06/25/24, 12:32

    The new clipboard can handle multiple types (and CTypes) at once, so this change is not needed anymore.
  24. Simon Schaufelberger commented on patch set 14 06/25/24, 13:45

    I'm quite sure there is a misunderstanding as this still doesn't work in main branch or am I wrong?
  25. Oli Bartsch commented on patch set 14 06/25/24, 14:02

    Reply Unresolved

    Hi, could you please provide the steps to reproduce what's not working in current main for you as I just checked myself and was able to add tt_content records with different CTypes's along with pages in the same clipboard and also successfully pasted them to another site.