Review 11.5 Merged

77734[BUGFIX] Avoid disabling page caches when having cHash validation enforced

Oliver Hader CR +2 V +2 Easy +6 −1 updated 02/07/23, 07:12

Commit message

If $GLOBALS['TYPO3_CONF_VARS']['FE']['cacheHash']['enforceValidation']
is enabled and the HTTP request only contains the `?id` query parameter,
caching for the page is disabled - which should be avoided.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 45

  1. Oliver Hader uploaded patch set 1 02/06/23, 22:51

  2. core-ci voted on patch set 1 V +1 02/06/23, 23:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37236

  3. Oli Bartsch voted on patch set 1 V +1 CR +1 02/07/23, 06:12

  4. Stefan Bürk voted on patch set 1 V +2 CR +2 02/07/23, 07:12

  5. Stefan Bürk merged patch set 2 02/07/23, 07:12