Review main Merged

77759Revert "[TASK] Replace localization methods in `PageLayoutController`"

Oli Bartsch CR +2 V +2 Normal +48 −5 updated 02/21/23, 09:57

Commit message

This reverts commit 7e10d6b5a9ae84b7ae77db872e44198f49b0c544.

Reason for revert: PageRepository->getPageOverlay() applies
frontend access restrictions, which are wrong in this context,
and which can not be skipped.

Additionally, the WorkspaceRestriction is not applied.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Stefan Bürk +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Jochen Roth +1
    • Stefan Bürk +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 811

  1. Oli Bartsch uploaded patch set 1 02/20/23, 12:55

  2. core-ci voted on patch set 1 V +1 02/20/23, 13:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37893

  3. Oli Bartsch uploaded patch set 2 V +1 02/20/23, 13:04

  4. Oli Bartsch updated the commit message in patch set 3 02/20/23, 13:11

  5. core-ci voted on patch set 2 V +1 02/20/23, 13:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37894

  6. core-ci voted on patch set 3 V +1 02/20/23, 13:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37897

  7. Andreas Kienast voted on patch set 3 V +1 CR +1 02/21/23, 09:46

  8. Stefan Bürk voted on patch set 3 V +1 CR +1 02/21/23, 09:50

  9. Jochen Roth voted on patch set 3 V +1 CR +1 02/21/23, 09:55

  10. Oli Bartsch voted on patch set 3 V +2 CR +2 02/21/23, 09:57

  11. Oli Bartsch merged patch set 4 02/21/23, 09:57