Review main Merged

77775[TASK] Add User- and PageTsConfig old include tag test coverage

Stefan Bürk CR +2 V +2 Easy +43 −0 updated 07/06/23, 11:42

Commit message

This change add additional functional tests to ensure old
import tag syntax works in PageTsConfig UserTsConfig,
from row templates and global array registration.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 1622

  1. Stefan Bürk uploaded patch set 1 02/07/23, 18:08

  2. Stefan Bürk updated the commit message in patch set 2 02/07/23, 18:09

  3. core-ci voted on patch set 1 V +1 02/07/23, 18:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37302

  4. core-ci voted on patch set 2 V +1 02/07/23, 18:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37303

  5. Stefan Bürk uploaded patch set 3 V +1 02/08/23, 10:40

  6. core-ci voted on patch set 3 V +1 02/08/23, 11:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37352

  7. Susi Moog voted on patch set 3 V +1 CR +1 07/04/23, 10:09

  8. Benni Mack commented on patch set 3 07/05/23, 13:00

    12.4 as well?
  9. Benni Mack updated the commit message in patch set 4 CR +1 V +1 07/05/23, 14:51

  10. Benni Mack voted on patch set 4 V +1 CR +1 07/05/23, 14:51

  11. Benni Mack voted on patch set 4 V 0 07/05/23, 14:52

  12. core-ci voted on patch set 4 V -1 07/05/23, 15:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43541

  13. Benni Mack voted on patch set 4 CR 0 07/05/23, 17:08

  14. Stefan Bürk uploaded patch set 5 V -1 07/06/23, 09:18

  15. Stefan Bürk updated the commit message in patch set 6 07/06/23, 09:50

  16. Stefan Bürk updated the commit message in patch set 7 07/06/23, 10:52

  17. core-ci voted on patch set 7 V +1 07/06/23, 11:10 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43699

  18. Christian Kuhn voted on patch set 7 V +1 CR +1 07/06/23, 11:19

  19. Benni Mack voted on patch set 7 V +1 CR +1 07/06/23, 11:19

  20. core-ci commented on patch set 7 07/06/23, 11:28 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43699

  21. Stefan Bürk voted on patch set 7 V +2 CR +2 07/06/23, 11:42

  22. Stefan Bürk merged patch set 8 07/06/23, 11:42