Review main Merged

77777[BUGFIX] Avoid invalid array key accesses in ext:linkvalidator

Stefan Bürk CR +2 V +2 Normal +41 −20 updated 04/11/23, 11:03

Commit message

Ensure that invalid array key accesses are properly guarded.

Additionally, fix the id of a language label, which was
incorrect.

All used variables are now initialized at the beginning of
ExternalLinkType::getErrorMessage().

Previously, the $errorParams['errorType'] was initialized in
one case with the status code. This is now changed so that
the HTTP status code is written to $errorParams['errno'].

In order to provide a generic error message, if the error
message cannot be obtained otherwise, a new language label
is added.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 2