77781[FEATURE] Allow editing of task groups within the scheduler module
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Markus Klein +1
-
Verified V +2 Done
- Benni Mack +2
- Markus Klein +1
- core-ci +1 CI
Issues 1
Files 21
- Build/Sources/Sass/module/_scheduler.scssnew+16 −0
- Build/Sources/Sass/backend.scss+1 −0
- Build/Sources/TypeScript/scheduler/scheduler-add-group.ts6new+114 −0
- Build/Sources/TypeScript/scheduler/scheduler-editable-group-name.ts2new+219 −0
- Build/Sources/TypeScript/scheduler/scheduler-sortable-groups.tsnew+61 −0
- typo3/sysext/backend/Resources/Public/Css/backend.css+1 −1
- typo3/sysext/core/Documentation/Changelog/12.3/Feature-99874-ManageSchdulerGroupsWithinBeModule.rstnew+28 −0
- typo3/sysext/core/Tests/Acceptance/Application/Scheduler/TaskGroupsCest.phpnew+86 −0
- typo3/sysext/core/Tests/Acceptance/Application/Scheduler/TasksCest.php+18 −34
- typo3/sysext/scheduler/Classes/Controller/SchedulerModuleController.php4+87 −23
- typo3/sysext/scheduler/Resources/Private/Language/locallang.xlf8+45 −2
- typo3/sysext/scheduler/Resources/Private/Partials/AddEditTaskGroupField.html+4 −3
- typo3/sysext/scheduler/Resources/Private/Partials/GroupUnusedList.htmlnew+95 −0
- typo3/sysext/scheduler/Resources/Private/Partials/TaskList.html+282 −216
- typo3/sysext/scheduler/Resources/Private/Templates/AddTaskForm.html+11 −2
- typo3/sysext/scheduler/Resources/Private/Templates/EditTaskForm.html+10 −1
- typo3/sysext/scheduler/Resources/Private/Templates/ListTasks.html+28 −13
- typo3/sysext/scheduler/Resources/Public/JavaScript/editable-group-title.jsnew+117 −0
- typo3/sysext/scheduler/Resources/Public/JavaScript/scheduler-add-group.jsnew+13 −0
- typo3/sysext/scheduler/Resources/Public/JavaScript/scheduler-editable-group-name.jsnew+110 −0
Review log 106181
Show 88156 earlier messages
-
Jochen Roth uploaded patch set 1 02/08/23, 08:24
-
Jochen Roth uploaded patch set 2 02/08/23, 08:28
-
core-ci voted on patch set 1 V -1 02/08/23, 08:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37335
-
core-ci voted on patch set 2 V -1 02/08/23, 08:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37338
-
Jochen Roth uploaded patch set 3
V -102/08/23, 09:14 -
core-ci voted on patch set 3 V -1 02/08/23, 09:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37342
-
Jasmina Ließmann uploaded patch set 4
V -102/08/23, 18:26 -
Jochen Roth uploaded patch set 5 02/08/23, 18:56
-
Jochen Roth uploaded patch set 6 02/08/23, 19:01
-
core-ci voted on patch set 4 V -1 02/08/23, 19:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37406
-
core-ci voted on patch set 6 V -1 02/08/23, 20:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37409
-
core-ci voted on patch set 5 V -1 02/08/23, 20:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37408
-
Jochen Roth uploaded patch set 7
V -102/09/23, 12:15 -
Jochen Roth uploaded patch set 8 02/09/23, 12:17
-
core-ci voted on patch set 7 V -1 02/09/23, 12:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37440
-
core-ci voted on patch set 8 V -1 02/09/23, 12:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37441
-
Jasmina Ließmann uploaded patch set 9
V -102/09/23, 12:40 -
Jochen Roth uploaded patch set 10 02/09/23, 12:48
-
core-ci voted on patch set 9 V -1 02/09/23, 12:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37446
-
core-ci voted on patch set 10 V -1 02/09/23, 13:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37448
-
Jochen Roth uploaded patch set 11
V -102/09/23, 14:03 -
core-ci voted on patch set 11 V -1 02/09/23, 14:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37464
-
Jochen Roth uploaded patch set 12
V -102/09/23, 14:30 -
Jochen Roth uploaded patch set 13 02/09/23, 14:36
-
core-ci voted on patch set 13 V -1 02/09/23, 14:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37474
-
core-ci voted on patch set 12 V -1 02/09/23, 14:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37473
-
Jochen Roth uploaded patch set 14
V -102/09/23, 15:15 -
Jochen Roth uploaded patch set 15 02/09/23, 15:18
-
core-ci voted on patch set 14 V -1 02/09/23, 15:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37479
-
Jochen Roth uploaded patch set 16 02/09/23, 15:54
-
core-ci voted on patch set 16 V -1 02/09/23, 16:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37481
-
Jochen Roth uploaded patch set 17
V -102/09/23, 16:38 -
core-ci voted on patch set 17 V +1 02/09/23, 16:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37483
-
Jochen Roth commented on patch set 17 CR -1 02/09/23, 16:56
On it. Will add a AC test for groups -
Jasmina Ließmann uploaded patch set 18
CR -1V +102/09/23, 18:04 -
Jasmina Ließmann commented on patch set 18 CR -1 02/09/23, 18:05
^ What Jochen said. -
core-ci voted on patch set 18 V +1 02/09/23, 18:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37487
-
Jochen Roth uploaded patch set 19
CR -1V +102/09/23, 18:25 -
core-ci voted on patch set 19 V +1 02/09/23, 18:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37489
-
Jochen Roth uploaded patch set 20
V +102/09/23, 19:29 -
core-ci voted on patch set 20 V -1 02/09/23, 20:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37496
-
Jasmina Ließmann uploaded patch set 21
V -102/09/23, 21:08 -
core-ci voted on patch set 21 V +1 02/09/23, 21:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37503
-
Jochen Roth uploaded patch set 22
V +102/09/23, 22:18 -
Jochen Roth commented on patch set 22 CR -1 02/09/23, 22:19
Still on it. Need to hide deleted groups. -
core-ci voted on patch set 22 V -1 02/09/23, 22:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37508
-
Jochen Roth uploaded patch set 23
CR -1V -102/10/23, 10:22 -
core-ci voted on patch set 23 V -1 02/10/23, 10:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37541
-
Josef Glatz commented on patch set 23 02/10/23, 13:24
locallang.xlf:184We can remove the bracket [ if there's no reason for the brackets.locallang.xlf:184We can remove the bracket ] if there's no reason for the brackets. -
Jochen Roth uploaded patch set 24
V -102/12/23, 23:19 -
core-ci voted on patch set 24 V -1 02/13/23, 00:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37623
-
Jochen Roth uploaded patch set 25
V -102/13/23, 16:29 -
core-ci voted on patch set 25 V -1 02/13/23, 16:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37657
-
Jochen Roth uploaded patch set 26
V -102/13/23, 17:06 -
Jochen Roth commented on patch set 26 02/13/23, 17:08
locallang.xlf:184ReplyDonelocallang.xlf:184ReplyDone -
core-ci voted on patch set 26 V -1 02/13/23, 17:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37659
-
Jochen Roth uploaded patch set 27
V -102/14/23, 11:18 -
Jochen Roth uploaded patch set 28 02/14/23, 11:19
-
core-ci voted on patch set 27 V -1 02/14/23, 11:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37679
-
core-ci voted on patch set 28 V -1 02/14/23, 11:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37680
-
Jochen Roth uploaded patch set 29
V -102/14/23, 12:01 -
Jochen Roth uploaded patch set 30 02/14/23, 12:30
-
core-ci voted on patch set 29 V -1 02/14/23, 12:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37687
-
Jochen Roth uploaded patch set 31 02/14/23, 12:47
-
core-ci voted on patch set 30 V -1 02/14/23, 12:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37689
-
core-ci voted on patch set 31 V -1 02/14/23, 13:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37691
-
Jochen Roth uploaded patch set 32
V -102/14/23, 15:05 -
core-ci voted on patch set 32 V -1 02/14/23, 15:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37698
-
core-ci commented on patch set 32 02/14/23, 15:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37698
-
Jochen Roth uploaded patch set 33
V -102/14/23, 16:45 -
core-ci voted on patch set 33 V -1 02/14/23, 16:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37703
-
Jochen Roth uploaded patch set 34
V -102/14/23, 16:50 -
core-ci voted on patch set 34 V +1 02/14/23, 16:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37704
-
Jochen Roth uploaded patch set 35
V +102/14/23, 17:42 -
Jochen Roth uploaded patch set 36 02/14/23, 17:43
-
Jochen Roth uploaded patch set 37 02/14/23, 17:50
-
core-ci voted on patch set 35 V -1 02/14/23, 17:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37706
-
core-ci voted on patch set 37 V +1 02/14/23, 17:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37708
-
core-ci voted on patch set 36 V -1 02/14/23, 18:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37707
-
Jochen Roth updated the commit message in patch set 38
V +102/15/23, 09:18 -
core-ci voted on patch set 38 V +1 02/15/23, 09:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37732
-
Jochen Roth commented on patch set 38 CR -1 02/15/23, 09:31
On it. Inline editing requires to be a post! -
Jochen Roth commented on patch set 38 CR 0 02/15/23, 10:39
Reply
Already done. -
Jochen Roth uploaded patch set 39
V +102/28/23, 11:07 -
Jochen Roth uploaded patch set 40 02/28/23, 11:50
-
core-ci voted on patch set 39 V -1 02/28/23, 11:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38195
-
core-ci voted on patch set 40 V -1 02/28/23, 12:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38199
-
Jochen Roth uploaded patch set 41
V -102/28/23, 13:43 -
Jochen Roth uploaded patch set 42 02/28/23, 14:04
-
core-ci voted on patch set 41 V -1 02/28/23, 14:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38210
-
core-ci voted on patch set 42 V -1 02/28/23, 14:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38213
-
Jochen Roth uploaded patch set 43
V -102/28/23, 14:32 -
core-ci voted on patch set 43 V -1 02/28/23, 14:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38215
-
Jochen Roth uploaded patch set 44
V -102/28/23, 15:12 -
core-ci voted on patch set 44 V +1 02/28/23, 15:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38216
-
Josef Glatz commented on patch set 44 03/02/23, 05:57
locallang.xlf:553Would also prefix this with "msg." like "msg.group.deleted" is prefixed. Or is the difference on purpose?locallang.xlf:556Would also prefix this with "msg." like "msg.group.delete.failed" is prefixed. Or is the difference on purpose? -
Josef Glatz commented on patch set 44 CR -1 03/02/23, 06:13
My feedback (short version): - contrast of edit button is to low. I think this should not be rated for this patch, since the page title inline editing uses the same - The inline edit UI feels crowded in a scheduler task group table header because of the task count after the edit button - mouse cursor: all other "actions" in the scheduler UI have a finger-cursor. This one has a normal pointer-cursor - New group modal: adding autofocus attribute to input would be a great benefit - be user gets not notified if the newly create group was renamed. The admin was informed via flash message after saving without this patch (since hideTable is active you can only add groups via the scheduler module) - Inline renaming does not show a renamed groupname if the new name would be a duplicate (you see the final name only on reloading the scheduler module) Beside the points above: I love the functionality and the feature itself! That way the scheduler groups will find more followers/users ❤️ +1 from that side!!! -
Jochen Roth uploaded patch set 45
CR -1V +103/02/23, 20:30 -
Jochen Roth commented on patch set 45 03/02/23, 20:54
Reply
> contrast of edit button is to low. I think this should not be rated for this patch, since the page title inline editing uses the same Done > The inline edit UI feels crowded in a scheduler task group table header because of the task count after the edit button Done, move below the table like it is done for be usergroups. > mouse cursor: all other "actions" in the scheduler UI have a finger-cursor. This one has a normal pointer-cursor Done > New group modal: adding autofocus attribute to input would be a great benefit Done > be user gets not notified if the newly create group was renamed. The admin was informed via flash message after saving without this patch (since hideTable is active you can only add groups via the scheduler module) Done, notification shows up again. > Inline renaming does not show a renamed groupname if the new name would be a duplicate (you see the final name only on reloading the scheduler module) Done. In case of an error, most likely due to name not being unique the content frame will reload now thanks -
Jochen Roth uploaded patch set 46 03/02/23, 21:22
-
core-ci voted on patch set 45 V -1 03/02/23, 21:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38328
-
core-ci voted on patch set 46 V -1 03/02/23, 22:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38329
-
Jochen Roth uploaded patch set 47
V -103/05/23, 22:45 -
Jochen Roth uploaded patch set 48 03/05/23, 22:56
-
core-ci voted on patch set 48 V -1 03/06/23, 00:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38503
-
core-ci voted on patch set 47 V -1 03/06/23, 00:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38502
-
core-ci voted on patch set 47 V -1 03/06/23, 00:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38502
-
Jochen Roth uploaded patch set 49
V -103/06/23, 08:40 -
Jochen Roth uploaded patch set 50 03/06/23, 08:56
-
core-ci voted on patch set 50 V +1 03/06/23, 09:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38522
-
core-ci voted on patch set 49 V -1 03/06/23, 09:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38518
-
Jochen Roth uploaded patch set 51
V +103/07/23, 13:38 -
core-ci voted on patch set 51 V +1 03/07/23, 13:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38603
-
Jochen Roth uploaded patch set 52
V +103/07/23, 14:27 -
Jochen Roth commented on patch set 52 03/07/23, 14:27
locallang.xlf:553ReplyDonelocallang.xlf:556ReplyDone -
Jochen Roth uploaded patch set 53 03/07/23, 14:29
-
core-ci voted on patch set 52 V +1 03/07/23, 14:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38607
-
core-ci voted on patch set 53 V +1 03/07/23, 15:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38608
-
Jochen Roth uploaded patch set 54
V +103/12/23, 19:14 -
core-ci voted on patch set 54 V -1 03/12/23, 20:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38846
-
Jochen Roth uploaded patch set 55
V -103/13/23, 10:08 -
core-ci voted on patch set 55 V -1 03/13/23, 10:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38869
-
Jochen Roth uploaded patch set 56
V -103/13/23, 10:43 -
core-ci voted on patch set 56 V +1 03/13/23, 10:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38873
-
Jochen Roth uploaded patch set 57
V +103/13/23, 11:46 -
Markus Klein commented on patch set 57 03/13/23, 11:56
Without reading the code, my first thought: this is clearly a new feature. And with this feature comes a documentation where it is actually documented then that you won't be able to find those records with the List module any longer. -
core-ci voted on patch set 57 V -1 03/13/23, 12:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38875
-
Jochen Roth uploaded patch set 58
V -103/13/23, 15:23 -
core-ci voted on patch set 58 V -1 03/13/23, 15:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38880
-
Jochen Roth uploaded patch set 59
V -103/13/23, 15:44 -
core-ci voted on patch set 59 V +1 03/13/23, 15:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38882
-
Markus Klein commented on patch set 60
V +103/13/23, 15:55Published edit on patch set 59. -
Markus Klein commented on patch set 60 03/13/23, 16:02
SchedulerModuleController.php:1073I would prefer to have explicit state instead of implicit. That means an additional parameter which defines the intended state: hidden yes or no. Toggle is always "dangerous". Constructed example: User A opens the module and sees the group activated. In the meantime some User B does the same and disables the group. Now User A clicks to "disable" the group and actually re-enables it. => Strange UX -
core-ci voted on patch set 60 V +1 03/13/23, 16:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38883
-
Markus Klein commented on patch set 60 03/13/23, 16:05
ext_tables.sql:26Are we silently dropping the description? If so => Breaking rst is necessary IMO -
Jochen Roth uploaded patch set 61
V +103/14/23, 14:20 -
core-ci voted on patch set 61 V -1 03/14/23, 14:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38932
-
Markus Klein commented on patch set 61 03/14/23, 15:06
Deprecation-99874-SchedulerGroupDescriptionField.rst:16Sorry, but this is not a deprecation. The idea of a deprecation is that things keep working as it was. The breaking change is anticipated to happen in the next version then. Simply keeping the DB field is IMO not a deprecation if the data is simply lost there and can't be displayed or edited. We have to find a solution here, because breaking changes are not allowed anymore for v12. One way would be to keep the table visible in the list module and to add the editing functionality as a new feature. We can deprecate the description usage then as it should and we can hide the table with v13 as breaking change (and drop the field). -
Markus Klein commented on patch set 61 03/14/23, 15:48
new feature just added: https://review.typo3.org/c/Packages/TYPO3.CMS/+/78118 -
Jochen Roth uploaded patch set 62
V -103/14/23, 16:52 -
Jochen Roth uploaded patch set 63 03/14/23, 16:59
-
core-ci voted on patch set 62 V +1 03/14/23, 17:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38939
-
core-ci voted on patch set 63 V +1 03/14/23, 17:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38941
-
Jochen Roth commented on patch set 63 03/14/23, 17:09
Deprecation-99874-SchedulerGroupDescriptionField.rst:16ReplyRemoved hideTable so the groups are still available in the list module.SchedulerModuleController.php:1073ReplyDoneext_tables.sql:26ReplyNot dropping the field anymore. -
Markus Klein commented on patch set 64
V +103/14/23, 19:03Published edit on patch set 63. -
Markus Klein commented on patch set 64 CR +1 03/14/23, 19:07
cool stuff. will test asap -
core-ci voted on patch set 64 V +1 03/14/23, 19:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38942
-
Andreas Kienast commented on patch set 64 CR -1 03/15/23, 07:33
scheduler-add-group.ts:35Please no. Use the regular validation API (`required`).scheduler-add-group.ts:48Please build a proper form, bind the `submit` event, and trigger `requestSubmit()` in the callback trigger.scheduler-add-group.ts:68primaryscheduler-editable-group-name.ts:167This misses validation - I can submit an empty form (DataHandler apparently doesn't do anything in this case). -
Jochen Roth uploaded patch set 65
CR +1V +103/15/23, 10:07 -
core-ci voted on patch set 65 V +1 03/15/23, 10:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38968
-
Jochen Roth commented on patch set 65 03/15/23, 10:15
Reply
Donescheduler-add-group.ts:35ReplyDonescheduler-add-group.ts:48ReplyDonescheduler-add-group.ts:68ReplyDonescheduler-editable-group-name.ts:167ReplyUsing `required` now. -
Jochen Roth commented on patch set 65 V -1 03/15/23, 10:29
On it. -
Jochen Roth uploaded patch set 66
V +103/15/23, 13:00 -
Jochen Roth uploaded patch set 67 03/15/23, 13:09
-
core-ci voted on patch set 66 V -1 03/15/23, 13:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38980
-
core-ci voted on patch set 67 V -1 03/15/23, 13:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38982
-
Jochen Roth uploaded patch set 68
V -103/15/23, 14:02 -
Jochen Roth uploaded patch set 69 03/15/23, 14:06
-
core-ci voted on patch set 69 V +1 03/15/23, 14:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38987
-
Markus Klein voted on patch set 69 V +1 CR +1 03/16/23, 09:50
-
Jochen Roth uploaded patch set 70
CR +1V +103/16/23, 10:36 -
core-ci voted on patch set 70 V -1 03/16/23, 10:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39048
-
Jochen Roth uploaded patch set 71
V -103/16/23, 11:43 -
core-ci voted on patch set 71 V +1 03/16/23, 11:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39053
-
Markus Klein voted on patch set 71 V +1 CR +1 03/20/23, 14:36
-
Jochen Roth uploaded patch set 72
CR +1V +103/21/23, 08:54 -
core-ci voted on patch set 72 V +1 03/21/23, 09:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39302
-
Markus Klein voted on patch set 72 V +1 CR +1 03/21/23, 09:13
-
Benni Mack commented on patch set 72 03/21/23, 09:31
I suggest to do the deprecation of the description field in a separate patch, as I think there is enough space to also show the description -
Jochen Roth uploaded patch set 73
CR +1V +103/21/23, 09:59 -
Jochen Roth uploaded patch set 74 03/21/23, 10:10
-
Jochen Roth uploaded patch set 75 03/21/23, 10:17
-
core-ci voted on patch set 74 V +1 03/21/23, 10:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39310
-
core-ci voted on patch set 73 V +1 03/21/23, 10:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39307
-
Jochen Roth commented on patch set 75 03/21/23, 10:31
Reply
-
core-ci voted on patch set 75 V +1 03/21/23, 10:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39311
-
Markus Klein voted on patch set 75 V +1 CR +1 03/21/23, 10:59
-
Benni Mack commented on patch set 75 V +2 CR +2 03/21/23, 11:21
We can and still should improve the styling, but I think we're good for the time being. -
Benni Mack merged patch set 76 03/21/23, 11:21
-
Christian Kuhn commented on patch set 76 03/22/23, 13:07
SchedulerModuleController.php:1067should be update(), otherwise record is fully deleted and not soft-deleted. -
Christian Kuhn commented on patch set 76 03/22/23, 13:12
SchedulerModuleController.php:1067Reply