Review main Merged

77781[FEATURE] Allow editing of task groups within the scheduler module

Jochen Roth CR +2 V +2 Expert +1359 −295 updated 03/22/23, 13:12

Commit message

Currently, users have to use the list module and click
on the root page to add/edit/remove a task group.

This has been changed by adding editing features for
groups within the module.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Markus Klein +1
  • Verified V +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • core-ci +1 CI

Issues 1

Files 21

Show 1 more file

Review log 106181

Show 88156 earlier messages
  1. Jochen Roth uploaded patch set 1 02/08/23, 08:24

  2. Jochen Roth uploaded patch set 2 02/08/23, 08:28

  3. core-ci voted on patch set 1 V -1 02/08/23, 08:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37335

  4. core-ci voted on patch set 2 V -1 02/08/23, 08:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37338

  5. Jochen Roth uploaded patch set 3 V -1 02/08/23, 09:14

  6. core-ci voted on patch set 3 V -1 02/08/23, 09:37 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37342

  7. Jasmina Ließmann uploaded patch set 4 V -1 02/08/23, 18:26

  8. Jochen Roth uploaded patch set 5 02/08/23, 18:56

  9. Jochen Roth uploaded patch set 6 02/08/23, 19:01

  10. core-ci voted on patch set 4 V -1 02/08/23, 19:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37406

  11. core-ci voted on patch set 6 V -1 02/08/23, 20:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37409

  12. core-ci voted on patch set 5 V -1 02/08/23, 20:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37408

  13. Jochen Roth uploaded patch set 7 V -1 02/09/23, 12:15

  14. Jochen Roth uploaded patch set 8 02/09/23, 12:17

  15. core-ci voted on patch set 7 V -1 02/09/23, 12:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37440

  16. core-ci voted on patch set 8 V -1 02/09/23, 12:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37441

  17. Jasmina Ließmann uploaded patch set 9 V -1 02/09/23, 12:40

  18. Jochen Roth uploaded patch set 10 02/09/23, 12:48

  19. core-ci voted on patch set 9 V -1 02/09/23, 12:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37446

  20. core-ci voted on patch set 10 V -1 02/09/23, 13:03 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37448

  21. Jochen Roth uploaded patch set 11 V -1 02/09/23, 14:03

  22. core-ci voted on patch set 11 V -1 02/09/23, 14:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37464

  23. Jochen Roth uploaded patch set 12 V -1 02/09/23, 14:30

  24. Jochen Roth uploaded patch set 13 02/09/23, 14:36

  25. core-ci voted on patch set 13 V -1 02/09/23, 14:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37474

  26. core-ci voted on patch set 12 V -1 02/09/23, 14:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37473

  27. Jochen Roth uploaded patch set 14 V -1 02/09/23, 15:15

  28. Jochen Roth uploaded patch set 15 02/09/23, 15:18

  29. core-ci voted on patch set 14 V -1 02/09/23, 15:19 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37479

  30. Jochen Roth uploaded patch set 16 02/09/23, 15:54

  31. core-ci voted on patch set 16 V -1 02/09/23, 16:09 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37481

  32. Jochen Roth uploaded patch set 17 V -1 02/09/23, 16:38

  33. core-ci voted on patch set 17 V +1 02/09/23, 16:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37483

  34. Jochen Roth commented on patch set 17 CR -1 02/09/23, 16:56

    On it. Will add a AC test for groups
  35. Jasmina Ließmann uploaded patch set 18 CR -1 V +1 02/09/23, 18:04

  36. Jasmina Ließmann commented on patch set 18 CR -1 02/09/23, 18:05

    ^ What Jochen said.
  37. core-ci voted on patch set 18 V +1 02/09/23, 18:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37487

  38. Jochen Roth uploaded patch set 19 CR -1 V +1 02/09/23, 18:25

  39. core-ci voted on patch set 19 V +1 02/09/23, 18:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37489

  40. Jochen Roth uploaded patch set 20 V +1 02/09/23, 19:29

  41. core-ci voted on patch set 20 V -1 02/09/23, 20:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37496

  42. Jasmina Ließmann uploaded patch set 21 V -1 02/09/23, 21:08

  43. core-ci voted on patch set 21 V +1 02/09/23, 21:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37503

  44. Jochen Roth uploaded patch set 22 V +1 02/09/23, 22:18

  45. Jochen Roth commented on patch set 22 CR -1 02/09/23, 22:19

    Still on it. Need to hide deleted groups.
  46. core-ci voted on patch set 22 V -1 02/09/23, 22:29 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37508

  47. Jochen Roth uploaded patch set 23 CR -1 V -1 02/10/23, 10:22

  48. core-ci voted on patch set 23 V -1 02/10/23, 10:45 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37541

  49. Josef Glatz commented on patch set 23 02/10/23, 13:24

    locallang.xlf:184

    We can remove the bracket [ if there's no reason for the brackets.

    locallang.xlf:184

    We can remove the bracket ] if there's no reason for the brackets.
  50. Jochen Roth uploaded patch set 24 V -1 02/12/23, 23:19

  51. core-ci voted on patch set 24 V -1 02/13/23, 00:24 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37623

  52. Jochen Roth uploaded patch set 25 V -1 02/13/23, 16:29

  53. core-ci voted on patch set 25 V -1 02/13/23, 16:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37657

  54. Jochen Roth uploaded patch set 26 V -1 02/13/23, 17:06

  55. Jochen Roth commented on patch set 26 02/13/23, 17:08

    locallang.xlf:184 Reply

    Done

    locallang.xlf:184 Reply

    Done
  56. core-ci voted on patch set 26 V -1 02/13/23, 17:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37659

  57. Jochen Roth uploaded patch set 27 V -1 02/14/23, 11:18

  58. Jochen Roth uploaded patch set 28 02/14/23, 11:19

  59. core-ci voted on patch set 27 V -1 02/14/23, 11:34 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37679

  60. core-ci voted on patch set 28 V -1 02/14/23, 11:35 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37680

  61. Jochen Roth uploaded patch set 29 V -1 02/14/23, 12:01

  62. Jochen Roth uploaded patch set 30 02/14/23, 12:30

  63. core-ci voted on patch set 29 V -1 02/14/23, 12:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37687

  64. Jochen Roth uploaded patch set 31 02/14/23, 12:47

  65. core-ci voted on patch set 30 V -1 02/14/23, 12:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37689

  66. core-ci voted on patch set 31 V -1 02/14/23, 13:14 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37691

  67. Jochen Roth uploaded patch set 32 V -1 02/14/23, 15:05

  68. core-ci voted on patch set 32 V -1 02/14/23, 15:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37698

  69. core-ci commented on patch set 32 02/14/23, 15:40 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37698

  70. Jochen Roth uploaded patch set 33 V -1 02/14/23, 16:45

  71. core-ci voted on patch set 33 V -1 02/14/23, 16:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37703

  72. Jochen Roth uploaded patch set 34 V -1 02/14/23, 16:50

  73. core-ci voted on patch set 34 V +1 02/14/23, 16:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37704

  74. Jochen Roth uploaded patch set 35 V +1 02/14/23, 17:42

  75. Jochen Roth uploaded patch set 36 02/14/23, 17:43

  76. Jochen Roth uploaded patch set 37 02/14/23, 17:50

  77. core-ci voted on patch set 35 V -1 02/14/23, 17:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37706

  78. core-ci voted on patch set 37 V +1 02/14/23, 17:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37708

  79. core-ci voted on patch set 36 V -1 02/14/23, 18:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37707

  80. Jochen Roth updated the commit message in patch set 38 V +1 02/15/23, 09:18

  81. core-ci voted on patch set 38 V +1 02/15/23, 09:26 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37732

  82. Jochen Roth commented on patch set 38 CR -1 02/15/23, 09:31

    On it. Inline editing requires to be a post!
  83. Jochen Roth commented on patch set 38 CR 0 02/15/23, 10:39

    Reply

    Already done.
  84. Jochen Roth uploaded patch set 39 V +1 02/28/23, 11:07

  85. Jochen Roth uploaded patch set 40 02/28/23, 11:50

  86. core-ci voted on patch set 39 V -1 02/28/23, 11:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38195

  87. core-ci voted on patch set 40 V -1 02/28/23, 12:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38199

  88. Jochen Roth uploaded patch set 41 V -1 02/28/23, 13:43

  89. Jochen Roth uploaded patch set 42 02/28/23, 14:04

  90. core-ci voted on patch set 41 V -1 02/28/23, 14:12 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38210

  91. core-ci voted on patch set 42 V -1 02/28/23, 14:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38213

  92. Jochen Roth uploaded patch set 43 V -1 02/28/23, 14:32

  93. core-ci voted on patch set 43 V -1 02/28/23, 14:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38215

  94. Jochen Roth uploaded patch set 44 V -1 02/28/23, 15:12

  95. core-ci voted on patch set 44 V +1 02/28/23, 15:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38216

  96. Josef Glatz commented on patch set 44 03/02/23, 05:57

    locallang.xlf:553

    Would also prefix this with "msg." like "msg.group.deleted" is prefixed. Or is the difference on purpose?

    locallang.xlf:556

    Would also prefix this with "msg." like "msg.group.delete.failed" is prefixed. Or is the difference on purpose?
  97. Josef Glatz commented on patch set 44 CR -1 03/02/23, 06:13

    My feedback (short version): - contrast of edit button is to low. I think this should not be rated for this patch, since the page title inline editing uses the same - The inline edit UI feels crowded in a scheduler task group table header because of the task count after the edit button - mouse cursor: all other "actions" in the scheduler UI have a finger-cursor. This one has a normal pointer-cursor - New group modal: adding autofocus attribute to input would be a great benefit - be user gets not notified if the newly create group was renamed. The admin was informed via flash message after saving without this patch (since hideTable is active you can only add groups via the scheduler module) - Inline renaming does not show a renamed groupname if the new name would be a duplicate (you see the final name only on reloading the scheduler module) Beside the points above: I love the functionality and the feature itself! That way the scheduler groups will find more followers/users ❤️ +1 from that side!!!
  98. Jochen Roth uploaded patch set 45 CR -1 V +1 03/02/23, 20:30

  99. Jochen Roth commented on patch set 45 03/02/23, 20:54

    Reply

    > contrast of edit button is to low. I think this should not be rated for this patch, since the page title inline editing uses the same Done > The inline edit UI feels crowded in a scheduler task group table header because of the task count after the edit button Done, move below the table like it is done for be usergroups. > mouse cursor: all other "actions" in the scheduler UI have a finger-cursor. This one has a normal pointer-cursor Done > New group modal: adding autofocus attribute to input would be a great benefit Done > be user gets not notified if the newly create group was renamed. The admin was informed via flash message after saving without this patch (since hideTable is active you can only add groups via the scheduler module) Done, notification shows up again. > Inline renaming does not show a renamed groupname if the new name would be a duplicate (you see the final name only on reloading the scheduler module) Done. In case of an error, most likely due to name not being unique the content frame will reload now thanks
  100. Jochen Roth uploaded patch set 46 03/02/23, 21:22

  101. core-ci voted on patch set 45 V -1 03/02/23, 21:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38328

  102. core-ci voted on patch set 46 V -1 03/02/23, 22:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38329

  103. Jochen Roth uploaded patch set 47 V -1 03/05/23, 22:45

  104. Jochen Roth uploaded patch set 48 03/05/23, 22:56

  105. core-ci voted on patch set 48 V -1 03/06/23, 00:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38503

  106. core-ci voted on patch set 47 V -1 03/06/23, 00:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38502

  107. core-ci voted on patch set 47 V -1 03/06/23, 00:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38502

  108. Jochen Roth uploaded patch set 49 V -1 03/06/23, 08:40

  109. Jochen Roth uploaded patch set 50 03/06/23, 08:56

  110. core-ci voted on patch set 50 V +1 03/06/23, 09:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38522

  111. core-ci voted on patch set 49 V -1 03/06/23, 09:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38518

  112. Jochen Roth uploaded patch set 51 V +1 03/07/23, 13:38

  113. core-ci voted on patch set 51 V +1 03/07/23, 13:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38603

  114. Jochen Roth uploaded patch set 52 V +1 03/07/23, 14:27

  115. Jochen Roth commented on patch set 52 03/07/23, 14:27

    locallang.xlf:553 Reply

    Done

    locallang.xlf:556 Reply

    Done
  116. Jochen Roth uploaded patch set 53 03/07/23, 14:29

  117. core-ci voted on patch set 52 V +1 03/07/23, 14:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38607

  118. core-ci voted on patch set 53 V +1 03/07/23, 15:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38608

  119. Jochen Roth uploaded patch set 54 V +1 03/12/23, 19:14

  120. core-ci voted on patch set 54 V -1 03/12/23, 20:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38846

  121. Jochen Roth uploaded patch set 55 V -1 03/13/23, 10:08

  122. core-ci voted on patch set 55 V -1 03/13/23, 10:16 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38869

  123. Jochen Roth uploaded patch set 56 V -1 03/13/23, 10:43

  124. core-ci voted on patch set 56 V +1 03/13/23, 10:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38873

  125. Jochen Roth uploaded patch set 57 V +1 03/13/23, 11:46

  126. Markus Klein commented on patch set 57 03/13/23, 11:56

    Without reading the code, my first thought: this is clearly a new feature. And with this feature comes a documentation where it is actually documented then that you won't be able to find those records with the List module any longer.
  127. core-ci voted on patch set 57 V -1 03/13/23, 12:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38875

  128. Jochen Roth uploaded patch set 58 V -1 03/13/23, 15:23

  129. core-ci voted on patch set 58 V -1 03/13/23, 15:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38880

  130. Jochen Roth uploaded patch set 59 V -1 03/13/23, 15:44

  131. core-ci voted on patch set 59 V +1 03/13/23, 15:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38882

  132. Markus Klein commented on patch set 60 V +1 03/13/23, 15:55

    Published edit on patch set 59.
  133. Markus Klein commented on patch set 60 03/13/23, 16:02

    SchedulerModuleController.php:1073

    I would prefer to have explicit state instead of implicit. That means an additional parameter which defines the intended state: hidden yes or no. Toggle is always "dangerous". Constructed example: User A opens the module and sees the group activated. In the meantime some User B does the same and disables the group. Now User A clicks to "disable" the group and actually re-enables it. => Strange UX
  134. core-ci voted on patch set 60 V +1 03/13/23, 16:03 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38883

  135. Markus Klein commented on patch set 60 03/13/23, 16:05

    ext_tables.sql:26

    Are we silently dropping the description? If so => Breaking rst is necessary IMO
  136. Jochen Roth uploaded patch set 61 V +1 03/14/23, 14:20

  137. core-ci voted on patch set 61 V -1 03/14/23, 14:30 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38932

  138. Markus Klein commented on patch set 61 03/14/23, 15:06

    Deprecation-99874-SchedulerGroupDescriptionField.rst:16

    Sorry, but this is not a deprecation. The idea of a deprecation is that things keep working as it was. The breaking change is anticipated to happen in the next version then. Simply keeping the DB field is IMO not a deprecation if the data is simply lost there and can't be displayed or edited. We have to find a solution here, because breaking changes are not allowed anymore for v12. One way would be to keep the table visible in the list module and to add the editing functionality as a new feature. We can deprecate the description usage then as it should and we can hide the table with v13 as breaking change (and drop the field).
  139. Markus Klein commented on patch set 61 03/14/23, 15:48

  140. Jochen Roth uploaded patch set 62 V -1 03/14/23, 16:52

  141. Jochen Roth uploaded patch set 63 03/14/23, 16:59

  142. core-ci voted on patch set 62 V +1 03/14/23, 17:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38939

  143. core-ci voted on patch set 63 V +1 03/14/23, 17:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38941

  144. Jochen Roth commented on patch set 63 03/14/23, 17:09

    Deprecation-99874-SchedulerGroupDescriptionField.rst:16 Reply

    Removed hideTable so the groups are still available in the list module.

    SchedulerModuleController.php:1073 Reply

    Done

    ext_tables.sql:26 Reply

    Not dropping the field anymore.
  145. Markus Klein commented on patch set 64 V +1 03/14/23, 19:03

    Published edit on patch set 63.
  146. Markus Klein commented on patch set 64 CR +1 03/14/23, 19:07

    cool stuff. will test asap
  147. core-ci voted on patch set 64 V +1 03/14/23, 19:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38942

  148. Andreas Kienast commented on patch set 64 CR -1 03/15/23, 07:33

    scheduler-add-group.ts:35

    Please no. Use the regular validation API (`required`).

    scheduler-add-group.ts:48

    Please build a proper form, bind the `submit` event, and trigger `requestSubmit()` in the callback trigger.

    scheduler-add-group.ts:68

    primary

    scheduler-editable-group-name.ts:167

    This misses validation - I can submit an empty form (DataHandler apparently doesn't do anything in this case).
  149. Jochen Roth uploaded patch set 65 CR +1 V +1 03/15/23, 10:07

  150. core-ci voted on patch set 65 V +1 03/15/23, 10:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38968

  151. Jochen Roth commented on patch set 65 03/15/23, 10:15

    Reply

    Done

    scheduler-add-group.ts:35 Reply

    Done

    scheduler-add-group.ts:48 Reply

    Done

    scheduler-add-group.ts:68 Reply

    Done

    scheduler-editable-group-name.ts:167 Reply

    Using `required` now.
  152. Jochen Roth commented on patch set 65 V -1 03/15/23, 10:29

    On it.
  153. Jochen Roth uploaded patch set 66 V +1 03/15/23, 13:00

  154. Jochen Roth uploaded patch set 67 03/15/23, 13:09

  155. core-ci voted on patch set 66 V -1 03/15/23, 13:13 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38980

  156. core-ci voted on patch set 67 V -1 03/15/23, 13:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38982

  1. Jochen Roth uploaded patch set 68 V -1 03/15/23, 14:02

  2. Jochen Roth uploaded patch set 69 03/15/23, 14:06

  3. core-ci voted on patch set 69 V +1 03/15/23, 14:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38987

  4. Markus Klein voted on patch set 69 V +1 CR +1 03/16/23, 09:50

  5. Jochen Roth uploaded patch set 70 CR +1 V +1 03/16/23, 10:36

  6. core-ci voted on patch set 70 V -1 03/16/23, 10:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39048

  7. Jochen Roth uploaded patch set 71 V -1 03/16/23, 11:43

  8. core-ci voted on patch set 71 V +1 03/16/23, 11:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39053

  9. Markus Klein voted on patch set 71 V +1 CR +1 03/20/23, 14:36

  10. Jochen Roth uploaded patch set 72 CR +1 V +1 03/21/23, 08:54

  11. core-ci voted on patch set 72 V +1 03/21/23, 09:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39302

  12. Markus Klein voted on patch set 72 V +1 CR +1 03/21/23, 09:13

  13. Benni Mack commented on patch set 72 03/21/23, 09:31

    I suggest to do the deprecation of the description field in a separate patch, as I think there is enough space to also show the description
  14. Jochen Roth uploaded patch set 73 CR +1 V +1 03/21/23, 09:59

  15. Jochen Roth uploaded patch set 74 03/21/23, 10:10

  16. Jochen Roth uploaded patch set 75 03/21/23, 10:17

  17. core-ci voted on patch set 74 V +1 03/21/23, 10:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39310

  18. core-ci voted on patch set 73 V +1 03/21/23, 10:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39307

  19. Jochen Roth commented on patch set 75 03/21/23, 10:31

  20. core-ci voted on patch set 75 V +1 03/21/23, 10:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39311

  21. Markus Klein voted on patch set 75 V +1 CR +1 03/21/23, 10:59

  22. Benni Mack commented on patch set 75 V +2 CR +2 03/21/23, 11:21

    We can and still should improve the styling, but I think we're good for the time being.
  23. Benni Mack merged patch set 76 03/21/23, 11:21

  24. Christian Kuhn commented on patch set 76 03/22/23, 13:07

    SchedulerModuleController.php:1067

    should be update(), otherwise record is fully deleted and not soft-deleted.
  25. Christian Kuhn commented on patch set 76 03/22/23, 13:12

    SchedulerModuleController.php:1067 Reply