Review main Merged

77782[BUGFIX] Fix label generation for inline files

Thomas Anders CR +2 V +2 Normal +56 −39 updated 07/31/23, 10:09

Commit message

The labels of inline FileReference fields were not concatenated
but overwritten, in a loop since #92427.

This patch corrects the concatenation and adds line-break divs,
otherwise the strings are on a single line.

Review

  • Code review CR +2 Done
    • Nikita Hovratov +2
    • Annett Jähnichen +1
  • Verified V +2 Done
    • Nikita Hovratov +2
    • Annett Jähnichen +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 2536

Show 711 earlier messages
  1. Thomas Anders uploaded patch set 1 02/08/23, 08:27

  2. core-ci voted on patch set 1 V -1 02/08/23, 08:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37337

  3. Thomas Anders uploaded patch set 2 02/08/23, 08:46

    Copied Votes: * Verified-1 (copy condition: "changekind:NO_CHANGE")
  4. core-ci voted on patch set 2 V -1 02/08/23, 09:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37339

  5. Thomas Anders uploaded patch set 3 V -1 02/08/23, 09:11

  6. core-ci voted on patch set 3 V +1 02/08/23, 09:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37341

  7. Benni Mack updated the commit message in patch set 4 V +1 05/03/23, 09:56

  8. Annett Jähnichen uploaded patch set 5 07/05/23, 19:26

  9. core-ci voted on patch set 5 V +1 07/05/23, 19:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43607

  10. Andreas Nedbal commented on patch set 5 CR -1 07/05/23, 20:01

    We're working on it
  11. Andreas Nedbal uploaded patch set 6 CR -1 V +1 07/07/23, 09:19

  1. core-ci voted on patch set 6 V -1 07/07/23, 09:36 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43877

  2. Andreas Nedbal uploaded patch set 7 V -1 07/07/23, 09:39

  3. core-ci voted on patch set 7 V +1 07/07/23, 09:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43879

  4. Annett Jähnichen voted on patch set 7 V +1 07/07/23, 09:53

  5. Annett Jähnichen voted on patch set 7 CR +1 07/07/23, 10:02

  6. Andreas Kienast voted on patch set 7 CR +1 07/07/23, 10:32

  7. Stefan Bürk updated the commit message in patch set 8 CR +1 V +1 07/21/23, 22:05

  8. Stefan Bürk updated the commit message in patch set 9 07/21/23, 22:07

  9. Stefan Bürk rebased onto patch set 10 07/21/23, 22:07

  10. core-ci voted on patch set 8 V +1 07/21/23, 22:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44403

  11. core-ci voted on patch set 10 V +1 07/21/23, 22:17 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44405

  12. core-ci voted on patch set 9 V +1 07/21/23, 22:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44404

  13. Andreas Kienast voted on patch set 10 CR +1 07/28/23, 13:48

  14. Annett Jähnichen voted on patch set 10 V +1 CR +1 07/28/23, 16:39

  15. Nikita Hovratov commented on patch set 10 V -1 07/31/23, 08:21

    Now I can only see the Filename or the title, but not both at the same time like in v10.
  16. Nikita Hovratov commented on patch set 10 V +1 07/31/23, 08:40

    Ah, sorry didn't see the filename is now in brackets
  17. Nikita Hovratov updated the commit message in patch set 11 CR +1 V +1 07/31/23, 08:45

  18. Nikita Hovratov commented on patch set 11 07/31/23, 08:46

    Would be nice to have the fix in v11 as well. The code should be almost identical, besides living in another class.
  19. core-ci voted on patch set 11 V +1 07/31/23, 08:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44784

  20. Nikita Hovratov updated the commit message in patch set 12 V +1 07/31/23, 09:08

  21. core-ci voted on patch set 12 V +1 07/31/23, 09:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/44786

  22. Nikita Hovratov voted on patch set 12 V +1 CR +1 07/31/23, 09:30

  23. Annett Jähnichen voted on patch set 12 V +1 CR +1 07/31/23, 09:31

  24. Nikita Hovratov voted on patch set 12 V +2 CR +2 07/31/23, 10:09

  25. Nikita Hovratov merged patch set 13 07/31/23, 10:09