Review main Merged

77784[BUGFIX] Fix PHP 8 warning in TypoScriptFrontendController

Thomas Hohn CR +2 V +2 Easy +1 −1 updated 02/10/23, 08:07

Commit message

Added Null coalescing operator, when accessing
$this->register['SYS_LASTCHANGED'].

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 913

  1. Thomas Hohn uploaded patch set 1 02/08/23, 09:44

  2. Benni Mack voted on patch set 1 CR +1 02/08/23, 09:47

  3. core-ci voted on patch set 1 V -1 02/08/23, 10:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37345

  4. Thomas Hohn uploaded patch set 2 02/08/23, 10:34

    Copied Votes: * Code-Review+1 (copy condition: "changekind:NO_CHANGE OR is:MIN") * Verified-1 (copy condition: "changekind:NO_CHANGE")
  5. core-ci voted on patch set 2 V -1 02/08/23, 10:53 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37350

  6. Thomas Hohn uploaded patch set 3 CR +1 V -1 02/08/23, 10:56

  7. Oliver Klee voted on patch set 3 CR +1 02/08/23, 10:59

  8. core-ci voted on patch set 3 V +1 02/08/23, 11:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37355

  9. Thomas Hohn updated the commit message in patch set 4 CR +1 V +1 02/08/23, 13:25

  10. core-ci voted on patch set 4 V +1 02/08/23, 13:44 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37365

  11. Benni Mack voted on patch set 4 V +1 CR +1 02/10/23, 08:03

  12. Georg Ringer voted on patch set 4 V +2 CR +2 02/10/23, 08:07

  13. Georg Ringer merged patch set 5 02/10/23, 08:07