Review main Merged

77806[TASK] Deprecate the limit parameter for GU::intExplode

Oliver Klee CR +2 V +2 Normal +53 −1 updated 02/14/23, 10:09

Commit message

Passing a limit to `GU::intExplode` will cause the method to
potentially return a string as the last array element, which
is not documented and directly contradicts the method contract
(which states that an array of integers will be returned).

The deprecated parameter is not used in the Core at all.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 3