Review main Merged

77807[TASK] Remove "hreflang" from site configuration

Benni Mack CR +2 V +2 Normal +152 −92 updated 11/06/24, 13:38

Commit message

With the introduction of the Locale API in 12.2
and its inclusion in SiteLanguage->getLocale(),
the property "hreflang" can be completely removed
from the Site Configuration, as the Locale API can
 convert the hreflang property properly into
a format like "de-AT" directly.

This format is described as IETF RFC 5646 language
tag standard: https://www.rfc-editor.org/rfc/rfc5646.html

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Anja Leichsenring +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Anja Leichsenring +1
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 43

Show 23 more files

Review log 913

  1. Benni Mack uploaded patch set 1 02/09/23, 14:56

  2. core-ci voted on patch set 1 V -1 02/09/23, 15:17 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37477

  3. Benni Mack uploaded patch set 2 V -1 02/09/23, 19:55

  4. core-ci voted on patch set 2 V -1 02/09/23, 20:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37501

  5. Benni Mack uploaded patch set 3 V -1 02/09/23, 21:19

  6. core-ci voted on patch set 3 V -1 02/09/23, 21:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37505

  7. Benni Mack uploaded patch set 4 V -1 02/09/23, 21:59

  8. core-ci voted on patch set 4 V +1 02/09/23, 22:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37507

  9. Anja Leichsenring voted on patch set 4 V +1 CR +1 02/10/23, 06:15

  10. Andreas Kienast voted on patch set 4 V +1 CR +1 02/10/23, 07:22

  11. Georg Ringer voted on patch set 4 V +2 CR +2 02/10/23, 07:45

  12. Georg Ringer merged patch set 5 02/10/23, 07:45

  13. Ingo Fabbri commented on patch set 5 11/06/24, 13:38

    How can a change that most would consider a breaking change be categorized as just a task?