Review main Merged

77808[BUGFIX] Guard ConstantEditor with copy operator in constants

Stefan Bürk CR +2 V +2 Easy +1 −0 updated 02/14/23, 12:13

Commit message

If copy operator '<' is used in TypoScript constants for a
constant with a constant editor configuration comment, the
"Call to member function getType() on null" exception is
emitted.

Example TypoScript constants:

>  # cat=custom/a; type=color; label=Primary Color
>  plugin.tx_example.primaryColor = #282E31
>
>  # cat=custom/a; type=color; label=Other Color
>  plugin.tx_example.otherColor < plugin.tx_example.primaryColor

This may happen when a comment token stream is
handled multiple times without being reset properly.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 1