Review main Merged

77815[BUGFIX] Sort and limit available locales in SiteLanguage selection

Benni Mack CR +2 V +2 Normal +49 −5 updated 02/10/23, 20:18

Commit message

When showing the available locales in the SiteLanguage
configuration, the selection is now sorted and also filtered,
by only showing "de_DE" and skipping locales with modifiers,
such as "de_DE.UTF-8" or "de_DE.ISO8859-1" in order to make
life easier for integrators.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Benni Mack +2
    • Oli Bartsch +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 1926

Show 1 earlier messages
  1. Benni Mack uploaded patch set 1 02/09/23, 22:38

  1. core-ci voted on patch set 1 V +1 02/09/23, 22:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37510

  2. Benni Mack uploaded patch set 2 V +1 02/10/23, 12:53

  3. Andreas Kienast commented on patch set 2 02/10/23, 13:01

    I have additional locales left not covered with this patch. Here's an excerpt: * aa_ER@saaho * be_BY@latin * bhb_IN.utf-8 * br_FR@euro * ca_ES@euro * ca_ES@valencia * gez_ER@abegede * ks_IN@devanagari

    UserFunctions.php:113

    There's also "C.UTF-8" on my system.
  4. core-ci voted on patch set 2 V +1 02/10/23, 13:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37554

  5. Benni Mack uploaded patch set 3 V +1 02/10/23, 14:12

  6. Benni Mack commented on patch set 3 02/10/23, 14:13

    Reply

    Also solved in the current patchset

    UserFunctions.php:113 Reply

    Done
  7. Benni Mack uploaded patch set 4 02/10/23, 14:30

  8. Benni Mack updated the commit message in patch set 5 02/10/23, 14:31

  9. core-ci voted on patch set 3 V -1 02/10/23, 14:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37562

  10. Andreas Kienast voted on patch set 5 V +1 CR +1 02/10/23, 14:38

  11. core-ci voted on patch set 4 V -1 02/10/23, 14:39 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37563

  12. core-ci voted on patch set 5 V -1 02/10/23, 14:46 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37564

  13. Benni Mack uploaded patch set 6 CR +1 V +1 02/10/23, 15:00

  14. core-ci voted on patch set 6 V +1 02/10/23, 15:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37572

  15. Andreas Kienast voted on patch set 6 V +1 CR +1 02/10/23, 15:31

  16. Christian Kuhn voted on patch set 6 V +1 CR +1 02/10/23, 16:10

  17. Stefan Bürk voted on patch set 6 V +1 CR +1 02/10/23, 16:34

  18. Oli Bartsch commented on patch set 6 CR -1 02/10/23, 17:24

    On it
  19. Oli Bartsch uploaded patch set 7 CR +1 V +1 02/10/23, 17:25

  20. Oli Bartsch voted on patch set 7 V +1 CR +1 02/10/23, 17:26

  21. Oli Bartsch commented on patch set 7 02/10/23, 17:26

    Reply

    Done
  22. core-ci voted on patch set 7 V +1 02/10/23, 17:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37576

  23. Stefan Bürk voted on patch set 7 V +1 CR +1 02/10/23, 17:42

  24. Benni Mack voted on patch set 7 V +2 CR +2 02/10/23, 20:18

  25. Benni Mack merged patch set 8 02/10/23, 20:18