77818[BUGFIX] Fix record history element viewport overflow
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Nikita Hovratov +1
-
Verified V +2 Done
- Stefan Bürk +2
- Nikita Hovratov +1
- core-ci +1 CI
Issues 1
Files 1
Review log 1724
-
Torben Hansen uploaded patch set 1 02/10/23, 06:46
-
core-ci voted on patch set 1 V +1 02/10/23, 06:52 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37520
-
Josef Glatz updated the commit message in patch set 2
V +102/10/23, 07:27 -
Josef Glatz commented on patch set 2 CR -1 02/10/23, 07:28
the second quotation is missing. Where does it end? After col? -
core-ci voted on patch set 2 V +1 02/10/23, 07:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37523
-
Torben Hansen updated the commit message in patch set 3
CR -1V +102/10/23, 07:35 -
Torben Hansen commented on patch set 3 02/10/23, 07:36
Reply
Done -
core-ci voted on patch set 3 V +1 02/10/23, 07:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37524
-
Torben Hansen uploaded patch set 4
V +102/22/23, 17:55 -
core-ci voted on patch set 4 V +1 02/22/23, 18:04 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37986
-
Josef Glatz uploaded patch set 5
V +102/28/23, 05:31 -
core-ci voted on patch set 5 V +1 02/28/23, 05:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38184
-
Josef Glatz commented on patch set 5 02/28/23, 05:41
I'm not sure whether this fixes the real problem. To me it looks like the "whole" template needs to be adjusted as there is no bootstrap-container-element at all. Looks like there were some one in history named `container-settings` (https://github.com/TYPO3/typo3/search?q=container-settings) but it has no CSS declaration (anymore). -
Torben Hansen commented on patch set 5 02/28/23, 18:23
Reply
Do we use the bootstrap container element in the backend? I could not really find any/many elements using `container` as class. AFAIK we just use row/col classes to align content in the `module-body` element. -
Jasmina Ließmann commented on patch set 5 03/01/23, 22:49
MultipleDiff.html:17Inserting a .col in this .row fixes the display issue for me, without having to add new divs on line 6 and 7, and also without changing the CSS. Could this be an alternative? -
Torben Hansen uploaded patch set 6
V +103/02/23, 14:33 -
Torben Hansen commented on patch set 6 03/02/23, 14:36
MultipleDiff.html:17ReplyThanks a lot. I checked your suggestion and it works perfectly. I updated the patch and it is ready for review. -
core-ci voted on patch set 6 V +1 03/02/23, 14:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38304
-
Jasmina Ließmann voted on patch set 6 V +1 CR +1 03/02/23, 15:55
-
Nikita Hovratov updated the commit message in patch set 7
CR +1V +103/02/23, 18:29 -
Nikita Hovratov commented on patch set 7 V +1 CR +1 03/02/23, 18:30
Can be easily backported for 11.5 too -
core-ci voted on patch set 7 V +1 03/02/23, 18:36 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38322
-
Stefan Bürk voted on patch set 7 V +2 CR +2 03/02/23, 19:11
-
Stefan Bürk merged patch set 8 03/02/23, 19:11