Review main Merged

77820[BUGFIX] Avoid clipped dropdowns in btn-groups

Benjamin Kott CR +2 V +2 Easy +12 −9 updated 02/10/23, 09:59

Commit message

The tables within the TYPO3 backend are wrapped within an element with overflow to enable scrolling and make them usable on smaller viewports.
The dropdowns with the TYPO3 backend are used in conjunction with button groups as a container that defines the position for child elements relative to the group. While non of these definition is a problem in it self, it leads to clipping dropdowns when used in combination.

Dropdown positions are calculated with JavaScript and placed absolute to the next relative container. Since the next container is inside the table that overflows, the dropdown display is cut off.

To resolve the issue for all placements, we define the standard behavior of button groups to be static. The parent container to calculate is now outside the table wrapper and the dropdown fully visible.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benni Mack +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 8

Review log 68

  1. Benjamin Kott uploaded patch set 1 02/10/23, 09:40

  2. Benjamin Kott commented on patch set 1 02/10/23, 09:41

    can be validated in filelist
  3. core-ci voted on patch set 1 V +1 02/10/23, 09:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37537

  4. Andreas Kienast updated the commit message in patch set 2 V +1 02/10/23, 09:52

  5. Andreas Kienast voted on patch set 2 V +1 CR +1 02/10/23, 09:52

  6. core-ci voted on patch set 2 V +1 02/10/23, 09:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37538

  7. Benni Mack voted on patch set 2 V +2 CR +2 02/10/23, 09:59

  8. Benni Mack merged patch set 3 02/10/23, 09:59