Review main Merged

77821[BUGFIX] Filter empty filelist actions after dispatching ProcessFileListActionsEvent

Andreas Kienast CR +2 V +2 Easy +4 −4 updated 02/10/23, 11:32

Commit message

When listing the contents of the folder "form_definitions",
`ProcessFileListActionsEventListener` modifies the available actions in
that directory by setting any disallowed action to `null`. With #99861,
a necessary null check was removed, leading to PHP warnings.

To solve the issue, `ProcessFileListActionsEventListener` now unsets
disallowed actions. Additionally, the `array_filter()` call to remove
empty actions is now executed after handling the
`ProcessFileListActionsEvent` event.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 2

Files 2