Review main Merged

77824[TASK] Avoid constructor pollution in InstallStatusReport

Christian Kuhn CR +2 V +2 Easy +0 −10 updated 02/10/23, 14:19

Commit message

The constructor argument is unused in core for
this internal class and can be removed.

This frees the constructor to be used for DI easily.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 2

Files 1

Review log 45

  1. Christian Kuhn uploaded patch set 1 02/10/23, 13:47

  2. Andreas Kienast voted on patch set 1 V +1 CR +1 02/10/23, 13:48

  3. core-ci voted on patch set 1 V +1 02/10/23, 13:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37558

  4. Anja Leichsenring voted on patch set 1 V +2 CR +2 02/10/23, 14:18

  5. Anja Leichsenring merged patch set 2 02/10/23, 14:19