Review main Merged

77828[TASK] Avoid GU::_GP() in UpgradeWizardService

Christian Kuhn CR +2 V +2 Easy +5 −7 updated 02/10/23, 17:14

Commit message

executeWizard() is only used in Web context.
UpgradeController has the request, prepares
arguments and feeds them to executeWizard()
now, instead of using GeneralUtility::_GP()
within the method.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Stefan Bürk +1
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 56

  1. Christian Kuhn uploaded patch set 1 02/10/23, 15:38

  2. core-ci voted on patch set 1 V +1 02/10/23, 15:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37574

  3. Benni Mack voted on patch set 1 V +1 CR +1 02/10/23, 15:56

  4. Stefan Bürk voted on patch set 1 V +1 CR +1 02/10/23, 16:26

  5. Christian Kuhn voted on patch set 1 V +2 CR +2 02/10/23, 17:14

  6. Christian Kuhn merged patch set 2 02/10/23, 17:14