Review main Merged

77836[TASK] Improve handling of non-versionable records

Lukas Niestroj CR +2 V +2 Normal +66 −6 updated 07/07/23, 12:13

Commit message

Rephrase the error messages presented to the user after a failed attempt
to create or update a version record in offline workspace without
permissions. Further, disable all modification actions in the
recordlist. Disabled buttons: edit, move, delete, copy, cut,
new record, history.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Susi Moog +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 2230

Show 35 earlier messages
  1. Lukas Niestroj uploaded patch set 1 02/13/23, 10:20

  2. core-ci voted on patch set 1 V -1 02/13/23, 11:05 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37635

  3. Lukas Niestroj uploaded patch set 2 V -1 02/13/23, 12:05

  4. core-ci voted on patch set 2 V +1 02/13/23, 12:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37643

  5. Lukas Niestroj commented on patch set 2 02/13/23, 20:08

    This patch is ready for review.
  1. Andreas Kienast commented on patch set 2 02/14/23, 10:10

    IMO that's a regular task, not a feature.
  2. Lukas Niestroj uploaded patch set 3 V +1 02/14/23, 19:14

  3. core-ci voted on patch set 3 V +1 02/14/23, 20:19 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37712

  4. Lukas Niestroj updated the commit message in patch set 4 V +1 02/15/23, 07:52

  5. core-ci voted on patch set 4 V +1 02/15/23, 08:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37725

  6. Anja Leichsenring voted on patch set 4 V +1 CR +1 02/16/23, 18:55

  7. Georg Ringer voted on patch set 4 V +1 CR +1 02/17/23, 06:28

  8. Benni Mack commented on patch set 4 03/22/23, 22:46

    Hey Lukas. Would it be possible to also modify FormEngine layout to see that it's not possible to edit such record in a workspace (as described in the ticket)?
  9. Lukas Niestroj uploaded patch set 5 CR +1 V +1 03/24/23, 13:47

  10. Lukas Niestroj commented on patch set 5 03/24/23, 13:50

    Reply

    A small badge is now shown between the table header and the table actions when the current table can not be edited withput live permission or without version enabled. Further, all actions which would end in the initial error message are disabled.
  11. core-ci voted on patch set 5 V +1 03/24/23, 13:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39553

  12. Benni Mack updated the commit message in patch set 6 V +1 05/03/23, 09:40

  13. Benni Mack rebased onto patch set 7 07/04/23, 20:07

  14. core-ci voted on patch set 7 V +1 07/04/23, 20:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43433

  15. Benni Mack voted on patch set 7 CR +1 07/04/23, 21:15

  16. Susi Moog commented on patch set 7 V -1 07/06/23, 09:37

    Even as admin user I cannot edit the records anymore in the workspace. Will try to fix.
  17. Susi Moog rebased onto patch set 8 CR +1 V +1 07/06/23, 11:25

  18. Susi Moog commented on patch set 8 07/06/23, 11:27

    Reply

    ... which is correct, because I did not understand that I needed to set the WS setting. I now just added an additional info in case editing _is_ enabled to warn the user, that these are live records.
  19. Susi Moog uploaded patch set 9 07/06/23, 11:30

  20. core-ci voted on patch set 8 V +1 07/06/23, 11:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43703

  21. core-ci voted on patch set 9 V +1 07/06/23, 11:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43705

  22. Susi Moog voted on patch set 9 V +1 CR +1 07/06/23, 11:54

  23. Benni Mack voted on patch set 9 V +2 CR +2 07/06/23, 11:57

  24. Benni Mack merged patch set 10 07/06/23, 11:57

  25. Lukas Niestroj commented on patch set 10 07/07/23, 12:13

    Thanks for the additions and feedback! Somehow it got merged very quickly. I hope it will help users to understand the complex behaviour of the workspaces a little more 😊