77841[FEATURE] Improve nested USER_INT/COA_INT rendering
Commit message
Review
-
Code review CR 0
-
Verified V 0
- core-ci +1 CI
Issues 1
Files 3
Review log 911
-
Lukas Niestroj uploaded patch set 1 02/13/23, 11:58
-
core-ci voted on patch set 1 V +1 02/13/23, 12:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37642
-
Lukas Niestroj commented on patch set 1 02/13/23, 20:10
Can someone help me with the test? Should I provide a Unit or Functional test? Do I test the TyposcripFrontendController or the ContentObjectRenderer? Any Advice? Thx -
Stefan Bürk commented on patch set 1 02/14/23, 20:35
Reply
That depends what should be tested, but for this change I would go more with functional test. You may want to look up the already existing tests in that area, e.g.: `typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php`Please keep an eye on commit message line length. ALso for the commit message below. See https://docs.typo3.org/m/typo3/guide-contributionworkflow/main/en-us/Appendix/CommitMessage.html for more details (commit message body max 72 chars, line breaks must be done manually) ... -
Lukas Niestroj uploaded patch set 2
V +102/15/23, 07:45 -
Lukas Niestroj commented on patch set 2 02/15/23, 07:48
Thanks Stefan. I ended up adding a Unit Test. I hope that is sufficient enough. If not, I can provide more.Reply
Done -
core-ci voted on patch set 2 V +1 02/15/23, 07:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37722
-
Oliver Hader commented on patch set 2 02/15/23, 08:00
What about moving this optimization to the TypoScript parser level already? This way it can be logged properly and adjusted in the actual TypoScript. -
Lukas Niestroj commented on patch set 2 02/15/23, 13:49
Reply
I will try that! Did not take a look at the new parser yet. -
Lukas Niestroj marked it work in progress 02/22/23, 16:14
-
Benni Mack abandoned the change 11/13/26, 17:32
wont do