Review main Abandoned

77841[FEATURE] Improve nested USER_INT/COA_INT rendering

Lukas Niestroj CR 0 V 0 Normal +121 −0 updated 11/13/26, 17:32

Commit message

The nesting of COA_INT objects would result in recursive calls for each new level
 of that *_INT object. However, for the first occurrence of COA_INT the caching
 for that object and nested objects is already disabled - thus it's not required
 to perform this task again. To improve this behaviour all nested *_INT objects
 will be converted to their respective counterpart.

Review

  • Code review CR 0
  • Verified V 0
    • core-ci +1 CI

Issues 1

Files 3

Review log 911

  1. Lukas Niestroj uploaded patch set 1 02/13/23, 11:58

  2. core-ci voted on patch set 1 V +1 02/13/23, 12:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37642

  3. Lukas Niestroj commented on patch set 1 02/13/23, 20:10

    Can someone help me with the test? Should I provide a Unit or Functional test? Do I test the TyposcripFrontendController or the ContentObjectRenderer? Any Advice? Thx
  4. Stefan Bürk commented on patch set 1 02/14/23, 20:35

    Reply

    That depends what should be tested, but for this change I would go more with functional test. You may want to look up the already existing tests in that area, e.g.: `typo3/sysext/frontend/Tests/Unit/ContentObject/ContentObjectRendererTest.php`
    Please keep an eye on commit message line length. ALso for the commit message below. See https://docs.typo3.org/m/typo3/guide-contributionworkflow/main/en-us/Appendix/CommitMessage.html for more details (commit message body max 72 chars, line breaks must be done manually) ...
  5. Lukas Niestroj uploaded patch set 2 V +1 02/15/23, 07:45

  6. Lukas Niestroj commented on patch set 2 02/15/23, 07:48

    Thanks Stefan. I ended up adding a Unit Test. I hope that is sufficient enough. If not, I can provide more.

    Reply

    Done
  7. core-ci voted on patch set 2 V +1 02/15/23, 07:55 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37722

  8. Oliver Hader commented on patch set 2 02/15/23, 08:00

    What about moving this optimization to the TypoScript parser level already? This way it can be logged properly and adjusted in the actual TypoScript.
  9. Lukas Niestroj commented on patch set 2 02/15/23, 13:49

    Reply

    I will try that! Did not take a look at the new parser yet.
  10. Lukas Niestroj marked it work in progress 02/22/23, 16:14

  11. Benni Mack abandoned the change 11/13/26, 17:32

    wont do