Review main Merged

77842[TASK] Refine LiveSearch search demand

Andreas Kienast CR +2 V +2 Hard +390 −68 updated 02/14/23, 08:46

Commit message

The search demand implementation used by the LiveSearch is refined to be
more flexible. Instead of a hard-coded list of properties, the
constructor now receives a list of `DemandProperty` instances that
accept everything that is backed by the `DemandPropertyName` enum,
allowing to pass only the required properties.

The `SearchDemand` class is immutable by design, it's API must not
allow modification by 3rd parties. However, there is an internal
`MutableSearchDemand` acting as a helper that allows to add / override
properties. A `SearchDemand` object may be constructed from a request
object, where it's payload must contain properties from the
aforementioned `DemandPropertyName` enum.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 1

Files 14