Review main Merged

77849[TASK] Move rename resource action to ajax

Benjamin Kott CR +2 V +2 Hard +384 −288 updated 02/24/23, 14:37

Commit message

This patch drops the dedicated resource rename view
and moves it to a modal view instead.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 20

Review log 2133

Show 48 earlier messages
  1. Benjamin Kott uploaded patch set 1 02/14/23, 11:33

  2. core-ci voted on patch set 1 V -1 02/14/23, 11:56 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37683

  3. Benjamin Kott uploaded patch set 2 V -1 02/16/23, 15:09

  4. core-ci voted on patch set 2 V -1 02/16/23, 16:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37810

  5. Benjamin Kott uploaded patch set 3 V -1 02/17/23, 07:40

  6. core-ci voted on patch set 3 V -1 02/17/23, 08:15 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37821

  7. Benjamin Kott uploaded patch set 4 V -1 02/21/23, 08:50

  8. core-ci voted on patch set 4 V -1 02/21/23, 09:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37917

  1. Benjamin Kott uploaded patch set 5 V -1 02/21/23, 11:52

  2. core-ci voted on patch set 5 V +1 02/21/23, 11:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37920

  3. Benjamin Kott uploaded patch set 6 V +1 02/21/23, 12:24

  4. Benjamin Kott uploaded patch set 7 02/21/23, 12:28

  5. core-ci voted on patch set 6 V -1 02/21/23, 12:33 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37921

  6. core-ci voted on patch set 7 V +1 02/21/23, 12:37 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37923

  7. Benni Mack commented on patch set 7 V +1 CR +1 02/21/23, 13:41

    We could improve the error handling in the future, while renaming. I tried renaming my jpg to a "myimage.php" file and the modal was gone, but I got a notication in the top right.
  8. Andreas Kienast uploaded patch set 8 CR +1 V +1 02/22/23, 10:17

  9. Christian Kuhn commented on patch set 8 02/22/23, 10:27

    ResourceController.php:38

    please declare final and @internal.
  10. core-ci voted on patch set 8 V +1 02/22/23, 11:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37963

  11. Benjamin Kott uploaded patch set 9 V +1 02/23/23, 10:11

  12. Benjamin Kott commented on patch set 9 02/23/23, 10:12

    ResourceController.php:38 Reply

    Done
  13. core-ci voted on patch set 9 V +1 02/23/23, 10:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38000

  14. Andreas Kienast commented on patch set 9 CR -1 02/23/23, 10:38

    file-list-rename-handler.ts:23

    Interface is unused, still required?

    file-list-rename-handler.ts:30

    Interface is unused, still required?

    file-list-rename-handler.ts:68

    form?.requestSubmit();

    file-list-rename-handler.ts:129

    You may add `required`, which is handled by `requestSubmit()`.

    ResourceController.php:76

    Could be converted to match(): ``` $message = match ($exception->getCode()) { 1676979120 => $this->getLanguageService()->sL('LLL:EXT:backend/Resources/Private/Language/locallang_resource.xlf:ajax.error.message.resourceNotFileOrFolder'), 1676299579 => $this->getLanguageService()->sL('LLL:EXT:backend/Resources/Private/Language/locallang_resource.xlf:ajax.error.message.resourceOutsideOfStorages'), 1676979130 => $this->getLanguageService()->sL('LLL:EXT:backend/Resources/Private/Language/locallang_resource.xlf:ajax.error.message.resourceNoPermissionRename'), 1676978732 => $this->getLanguageService()->sL('LLL:EXT:backend/Resources/Private/Language/locallang_resource.xlf:ajax.error.message.resourceNameCannotBeEmpty'), default => $exception->getMessage(), }; ```

    ResourceController.php:122

    return

    locallang_resource.xlf:7

    `resname` is missing

    locallang_resource.xlf:13

    `resname` is missing
  15. Benni Mack commented on patch set 9 02/23/23, 14:23

    ResourceController.php:55

    $identifier does not need to be a class member. method could be named "renameResourceAction"
  16. Benjamin Kott uploaded patch set 10 CR -1 V +1 02/24/23, 09:17

  17. Benjamin Kott uploaded patch set 11 02/24/23, 09:21

  18. Benjamin Kott commented on patch set 11 02/24/23, 09:21

    file-list-rename-handler.ts:23 Reply

    Done

    file-list-rename-handler.ts:30 Reply

    Done

    file-list-rename-handler.ts:68 Reply

    Done

    file-list-rename-handler.ts:129 Reply

    Done

    ResourceController.php:55 Reply

    Done

    ResourceController.php:76 Reply

    Done

    ResourceController.php:122 Reply

    Done

    locallang_resource.xlf:7 Reply

    Done

    locallang_resource.xlf:13 Reply

    Done
  19. core-ci voted on patch set 11 V -1 02/24/23, 10:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38043

  20. core-ci voted on patch set 10 V -1 02/24/23, 10:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38042

  21. Benjamin Kott uploaded patch set 12 V -1 02/24/23, 10:33

  22. core-ci voted on patch set 12 V +1 02/24/23, 10:40 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38045

  23. Benni Mack voted on patch set 12 V +1 CR +1 02/24/23, 13:20

  24. Andreas Kienast voted on patch set 12 V +2 CR +2 02/24/23, 14:37

  25. Andreas Kienast merged patch set 13 02/24/23, 14:37