Review main Merged

77853[TASK] Refine LiveSearch form behavior

Andreas Kienast CR +2 V +2 Normal +101 −85 updated 02/15/23, 15:09

Commit message

The behavior of the LiveSearch form used in the modal window is refined
in several ways.

The most important change is the usage of `SearchDemand` to pre-fill the
search form. This required to add a `form` tag and to rename the
`searchField` field to `query` to align with the `SearchDemand`
requirements. Also, the `q` argument is renamed to `query` as well.

Instead of directly triggering the search at several locations, a form
submit is request. This allows to call `search()` only once and to
provide a `FormData` object, containing all fields and values for the
underlying AJAX request. With this, there is no need to store the values
in properties anymore (`this.searchTerm` and `this.searchProperties`),
which are dropped now.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Frank Nägler +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Frank Nägler +1
    • core-ci +1 CI

Issues 1

Files 7

Review log 813

  1. Andreas Kienast uploaded patch set 1 02/14/23, 14:49

  2. Andreas Kienast uploaded patch set 2 02/14/23, 14:51

  3. Andreas Kienast uploaded patch set 3 02/14/23, 14:52

  4. core-ci voted on patch set 1 V -1 02/14/23, 15:01 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37695

  5. core-ci voted on patch set 2 V -1 02/14/23, 15:02 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37696

  6. core-ci voted on patch set 3 V -1 02/14/23, 15:10 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37697

  7. Andreas Kienast uploaded patch set 4 V -1 02/15/23, 07:49

  8. core-ci voted on patch set 4 V +1 02/15/23, 07:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37723

  9. Andreas Kienast uploaded patch set 5 V +1 02/15/23, 12:14

  10. core-ci voted on patch set 5 V +1 02/15/23, 12:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37742

  11. Frank Nägler voted on patch set 5 V +1 CR +1 02/15/23, 13:09

  12. Andreas Kienast voted on patch set 5 V +2 CR +2 02/15/23, 15:09

  13. Andreas Kienast merged patch set 6 02/15/23, 15:09