Review main Merged

77865[BUGFIX] Position sidebar in image cropping correctly on the right

Jochen Roth CR +2 V +2 Easy +10 −4 updated 02/15/23, 15:41

Commit message

Currently, the sidebar containing the cropVariants
is always positioned below.

This has been fixed by adding a missing display flex
to the modal on sm-viewport and up.

On top of that the undefined this.cropBox error
on modal load was fixed by adding a empty JQuery object
on initialization.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Andreas Kienast +1
    • core-ci +1 CI

Issues 1

Files 4

Review log 1014

  1. Jochen Roth uploaded patch set 1 02/15/23, 12:56

  2. Jochen Roth updated the commit message in patch set 2 02/15/23, 12:58

  3. core-ci voted on patch set 1 V +1 02/15/23, 13:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37745

  4. core-ci voted on patch set 2 V +1 02/15/23, 13:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37748

  5. Oli Bartsch voted on patch set 2 CR +1 02/15/23, 13:17

  6. Jochen Roth commented on patch set 2 V -1 02/15/23, 13:38

    On it. Andy discovered a nasty double scrollbar.
  7. Jochen Roth uploaded patch set 3 CR +1 V +1 02/15/23, 13:45

  8. Andreas Kienast commented on patch set 3 CR -1 02/15/23, 13:52

    I'd recover Patch Set 2. It's the same behavior in v11 and also, the cropper is fantastically broken if the image needs more space than the viewport can deliver.
  9. Andreas Kienast uploaded patch set 4 CR -1 02/15/23, 13:53

  10. Andreas Kienast voted on patch set 4 V +1 CR +1 02/15/23, 13:54

  11. core-ci voted on patch set 3 V +1 02/15/23, 13:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37751

  12. core-ci voted on patch set 4 V +1 02/15/23, 14:01 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37753

  13. Oli Bartsch voted on patch set 4 V +2 CR +2 02/15/23, 15:41

  14. Oli Bartsch merged patch set 5 02/15/23, 15:41