Review main Merged

77868[BUGFIX] Make system information message link binding independent

Benjamin Kott CR +2 V +2 Normal +94 −80 updated 02/21/23, 08:38

Commit message

The link binding of the system information menu messages reuses
module menu identifiers but does not embrace them to avoid additional
attributes on links. We reworked the message link binding to make it
independent from existing link binding and avoid further conflicts.

Instead of refreshing the link bindings after each data fetch, we are
moving the registration for the link click handler to the static parent
element. The link binding now keeps intact after fetching new data.

We currently dont have an encapsulated component for the system
information menu. To avoid nested document queries we are
hardening the selectors for now. In this step we are also removing
jQuery from the system information menu, as there is no use for
this here anymore.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 811

  1. Benjamin Kott uploaded patch set 1 02/15/23, 15:04

  2. core-ci voted on patch set 1 V +1 02/15/23, 15:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37759

  3. Andreas Kienast commented on patch set 1 CR -1 02/16/23, 08:20

    on it
  4. Andreas Kienast uploaded patch set 2 CR -1 V +1 02/16/23, 08:26

  5. Andreas Kienast uploaded patch set 3 02/16/23, 08:32

  6. Andreas Kienast voted on patch set 3 V +1 CR +1 02/16/23, 08:33

  7. core-ci voted on patch set 2 V +1 02/16/23, 08:33 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37788

  8. core-ci voted on patch set 3 V +1 02/16/23, 08:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37789

  9. Oli Bartsch voted on patch set 3 V +1 CR +1 02/17/23, 14:44

  10. Andreas Kienast voted on patch set 3 V +2 CR +2 02/21/23, 08:38

  11. Andreas Kienast merged patch set 4 02/21/23, 08:38