Review main Merged

77870[TASK] Clean up Expression Language Resolver class

Christian Kuhn CR +2 V +2 Easy +4 −16 updated 02/16/23, 09:54

Commit message

A warmup patch preparing more work in this area:
* Remove unused property
* Private over protected
* Comments
* Property type hints

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1113

  1. Christian Kuhn uploaded patch set 1 02/15/23, 15:44

  2. Christian Kuhn voted on patch set 1 V +1 CR +1 02/15/23, 15:45

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 02/15/23, 15:49

  4. core-ci voted on patch set 1 V -1 02/15/23, 15:51 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37764

  5. Oli Bartsch commented on patch set 1 02/15/23, 16:08

    Resolver.php:30

    Should be removed since it's always overwritten in the constructor.
  6. Stefan Bürk voted on patch set 1 V 0 CR 0 02/15/23, 17:58

  7. Christian Kuhn uploaded patch set 2 CR +1 V +1 02/16/23, 08:44

  8. Christian Kuhn commented on patch set 2 02/16/23, 08:45

    Resolver.php:30 Reply

    Done
  9. core-ci voted on patch set 2 V +1 02/16/23, 08:51 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37790

  10. Stefan Bürk voted on patch set 2 V +1 CR +1 02/16/23, 08:51

  11. Anja Leichsenring commented on patch set 2 02/16/23, 09:52

    Resolver.php:30

    will that work without value initialization? Unsure, we saw errors in similar situations.
  12. Oli Bartsch commented on patch set 2 V +2 CR +2 02/16/23, 09:54

    Resolver.php:30 Reply

    Please see my comment from above.
  13. Oli Bartsch merged patch set 3 02/16/23, 09:54