Review main Abandoned

77871[BUGFIX] Auto create match fields of mm tables

Georg Ringer CR 0 V 0 Normal +86 −0 updated 08/28/23, 10:48

Commit message

If match fields are defined in the TCA for mm tables, those are created
automatically.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 1821

  1. Georg Ringer uploaded patch set 1 02/15/23, 15:50

  2. Georg Ringer commented on patch set 1 02/15/23, 15:50

    This change is ready for review.
  3. core-ci voted on patch set 1 V -1 02/15/23, 15:57 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37765

  4. Georg Ringer uploaded patch set 2 V -1 02/15/23, 20:07

  5. core-ci voted on patch set 2 V +1 02/15/23, 20:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37777

  6. Benni Mack voted on patch set 2 CR +1 03/07/23, 16:40

  7. Oliver Klee commented on patch set 2 03/07/23, 17:07

    Isn't this rather a [FEATURE]? Or was this supposed to work before?
  8. David Bruchmann commented on patch set 2 03/07/23, 20:08

    Reply

    The [FEATURE] did exist already but it was buggy, so I consider it as [BUGFIX]. My bug report clarifies it.
  9. Oliver Klee wrote 03/07/23, 22:29

    Removed cc Oliver Klee.
  10. Jochen Roth voted on patch set 2 V +1 CR +1 03/16/23, 16:49

  11. Stefan Bürk voted on patch set 2 V +1 CR +1 03/18/23, 12:03

  12. Christian Kuhn voted on patch set 2 CR -1 03/21/23, 11:36

  13. Christian Kuhn commented on patch set 2 03/21/23, 11:51

    I don't think we should auto-create fields based on MM_match_fields, since that field should vanish altogether. Using it on the local side indicates a broken TCA MM configuration. See my comment in the forge issue for more details on this.
  14. Stefan Bürk voted on patch set 2 V 0 CR 0 03/21/23, 12:15

  15. Georg Ringer commented on patch set 2 03/21/23, 13:47

    Reply

    TBH don't really understand it. just because we might/will deprecate it in a year we can still improve the life of users *now*
  16. Christian Kuhn commented on patch set 2 03/21/23, 15:19

    Reply

    The point is: MM_match_fields is only useful on 'foreign_side'. the DefaultSchemaGenerator returns early when looking at MM from foreign side. Having MM_match_fields on local side indicates "you're doing it wrong". The blog_example is actively broken in this regard at the moment and should be fixed instead, leading to a config that does not use MM_match_fields on local side anymore. This was the reason I did not add handling of MM_match_fields for #95061 in the first place. Note ext_tables.sql of blog_example test extension has @todo's for this already, as well. We should not add core code supporting broken TCA config, so the patch should not be merged.
  17. Benni Mack updated the commit message in patch set 3 CR +1 V +1 05/03/23, 09:39

  18. Simon Schaufelberger uploaded patch set 4 08/20/23, 18:20

  19. core-ci voted on patch set 4 V -1 08/20/23, 18:27 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/45645

  20. Christian Kuhn commented on patch set 4 08/28/23, 10:48

    Hey. I'll abandon here - blog_example has been fixed in this regard meanwhile, MM_match_fields should not be set for the 'local' side of an MM relation, which is what DefaultTcaSchema looks at exclusively.
  21. Christian Kuhn abandoned the change 08/28/23, 10:48