77874[TASK] Streamline backend user/-group total amount output
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Oliver Klee +1
- Jochen Roth +1
-
Verified V +2 Done
- Benni Mack +2
- Jochen Roth +1
- core-ci +1 CI
Issues 1
Files 5
- typo3/sysext/beuser/Resources/Private/Language/locallang.xlf+9 −3
- typo3/sysext/beuser/Resources/Private/Partials/BackendUser/PaginatedList.html2+4 −3
- typo3/sysext/beuser/Resources/Private/Partials/BackendUserGroup/PaginatedList.html+4 −1
- typo3/sysext/beuser/Resources/Private/Templates/BackendUser/Online.html+11 −0
- typo3/sysext/core/Tests/Acceptance/Application/BackendUser/ListUserCest.php+1 −1
Review log 1621
-
Josef Glatz uploaded patch set 1 02/15/23, 17:14
-
Josef Glatz commented on patch set 1 02/15/23, 17:15
This change is ready for review. -
Oliver Klee commented on patch set 1 CR +1 02/15/23, 17:33
This indeed is an improvement. Thanks! (We should keep in mind, though, that this approach (having a singular form and only one plural form) does not work in all languages: Some languages have multiple plural forms depending on the exact number of the objects: https://lingohub.com/blog/2019/02/pluralization XLIFF actually supports this (AFAIK), but our implementation does not (yet).) -
core-ci voted on patch set 1 V -1 02/15/23, 17:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37772
-
Georg Ringer commented on patch set 1 02/16/23, 06:06
as the translation is added to 11.5 automatically as well, what about improving 11.5 too?PaginatedList.html:25I am in favor of {totalAmountOfBackendUsers} {f:if(condition:'{totalAmountOfBackendUsers} > 1', then:'{f:translate(key:\'users\')}'} -
Jochen Roth uploaded patch set 2
CR +1V -103/17/23, 10:06 -
core-ci voted on patch set 2 V +1 03/17/23, 10:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39111
-
Oliver Klee voted on patch set 2 CR +1 03/17/23, 10:19
-
Jochen Roth uploaded patch set 3
CR +1V +107/04/23, 10:35 -
core-ci voted on patch set 3 V +1 07/04/23, 10:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43363
-
Benni Mack commented on patch set 3 07/04/23, 12:12
BackendUserController.php:207we do have <f:count> ? -
Jochen Roth uploaded patch set 4
V +107/04/23, 13:33 -
Jochen Roth commented on patch set 4 07/04/23, 13:34
BackendUserController.php:207ReplyAck -
core-ci voted on patch set 4 V +1 07/04/23, 13:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43384
-
Benni Mack updated the commit message in patch set 5
V +107/04/23, 20:01 -
Benni Mack commented on patch set 5 V +1 CR +1 07/04/23, 20:02
PaginatedList.html:25Replylet's just get it in. -
Oliver Klee voted on patch set 5 CR +1 07/04/23, 20:06
-
core-ci voted on patch set 5 V +1 07/04/23, 20:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43430
-
Jochen Roth voted on patch set 5 V +1 CR +1 07/05/23, 07:27
-
Benni Mack voted on patch set 5 V +2 CR +2 07/05/23, 13:02
-
Benni Mack merged patch set 6 07/05/23, 13:02