Review main Merged

77874[TASK] Streamline backend user/-group total amount output

Josef Glatz CR +2 V +2 Easy +29 −8 updated 07/05/23, 13:02

Commit message

Streamline total amount text for backend groups and backend
user listing. Also correct wording is applied, depending on
the number of records displayed.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Oliver Klee +1
    • Jochen Roth +1
  • Verified V +2 Done
    • Benni Mack +2
    • Jochen Roth +1
    • core-ci +1 CI

Issues 1

Files 5

Review log 1621

  1. Josef Glatz uploaded patch set 1 02/15/23, 17:14

  2. Josef Glatz commented on patch set 1 02/15/23, 17:15

    This change is ready for review.
  3. Oliver Klee commented on patch set 1 CR +1 02/15/23, 17:33

    This indeed is an improvement. Thanks! (We should keep in mind, though, that this approach (having a singular form and only one plural form) does not work in all languages: Some languages have multiple plural forms depending on the exact number of the objects: https://lingohub.com/blog/2019/02/pluralization XLIFF actually supports this (AFAIK), but our implementation does not (yet).)
  4. core-ci voted on patch set 1 V -1 02/15/23, 17:47 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37772

  5. Georg Ringer commented on patch set 1 02/16/23, 06:06

    as the translation is added to 11.5 automatically as well, what about improving 11.5 too?

    PaginatedList.html:25

    I am in favor of {totalAmountOfBackendUsers} {f:if(condition:'{totalAmountOfBackendUsers} > 1', then:'{f:translate(key:\'users\')}'}
  6. Jochen Roth uploaded patch set 2 CR +1 V -1 03/17/23, 10:06

  7. core-ci voted on patch set 2 V +1 03/17/23, 10:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/39111

  8. Oliver Klee voted on patch set 2 CR +1 03/17/23, 10:19

  9. Jochen Roth uploaded patch set 3 CR +1 V +1 07/04/23, 10:35

  10. core-ci voted on patch set 3 V +1 07/04/23, 10:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43363

  11. Benni Mack commented on patch set 3 07/04/23, 12:12

    BackendUserController.php:207

    we do have <f:count> ?
  12. Jochen Roth uploaded patch set 4 V +1 07/04/23, 13:33

  13. Jochen Roth commented on patch set 4 07/04/23, 13:34

    BackendUserController.php:207 Reply

    Ack
  14. core-ci voted on patch set 4 V +1 07/04/23, 13:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43384

  15. Benni Mack updated the commit message in patch set 5 V +1 07/04/23, 20:01

  16. Benni Mack commented on patch set 5 V +1 CR +1 07/04/23, 20:02

    PaginatedList.html:25 Reply

    let's just get it in.
  17. Oliver Klee voted on patch set 5 CR +1 07/04/23, 20:06

  18. core-ci voted on patch set 5 V +1 07/04/23, 20:23 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43430

  19. Jochen Roth voted on patch set 5 V +1 CR +1 07/05/23, 07:27

  20. Benni Mack voted on patch set 5 V +2 CR +2 07/05/23, 13:02

  21. Benni Mack merged patch set 6 07/05/23, 13:02