Review main Merged

77875[BUGFIX] Translate lowlevel database search form

Josef Glatz CR +2 V +2 Easy +23 −5 updated 07/05/23, 17:34

Commit message

This patch adds missing translation strings for the search
located in: DB Check > Full search > Raw search in all fields

The heading of the result section is also only shown if result
markup is available to the view from now on.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 1521

  1. Josef Glatz uploaded patch set 1 02/15/23, 17:40

  2. Josef Glatz commented on patch set 1 02/15/23, 17:41

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 02/15/23, 17:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37773

  4. Josef Glatz uploaded patch set 2 V +1 02/15/23, 17:50

  5. Josef Glatz updated the commit message in patch set 3 02/15/23, 17:51

  6. core-ci voted on patch set 3 V -1 02/15/23, 18:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37775

  7. core-ci voted on patch set 2 V -1 02/15/23, 18:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37774

  8. Josef Glatz commented on patch set 3 CR -1 02/15/23, 18:19

    todo: adopt acceptance tests
  9. Georg Ringer commented on patch set 3 02/16/23, 06:06

    what about adding it to 11.5 too, the translation i there as well
  10. Oli Bartsch commented on patch set 3 CR -1 02/16/23, 07:45

    CustomSearch.html:30

    Instead of hiding the this section I would prefer to add a note, at least in case a search term has been entered which yields no results.
  11. Benni Mack updated the commit message in patch set 4 CR -1 V -1 05/03/23, 09:54

  12. Oli Bartsch uploaded patch set 5 07/05/23, 14:48

  13. core-ci voted on patch set 5 V +1 07/05/23, 15:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43538

  14. Oli Bartsch uploaded patch set 6 V +1 07/05/23, 15:24

  15. Oli Bartsch commented on patch set 6 V +1 CR +1 07/05/23, 15:25

    Reply

    Done

    CustomSearch.html:30 Reply

    Done
  16. core-ci voted on patch set 6 V -1 07/05/23, 15:42 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43545

  17. Benni Mack rebased onto patch set 7 CR +1 V +1 07/05/23, 17:07

  18. Benni Mack voted on patch set 7 V +1 CR +1 07/05/23, 17:07

  19. core-ci voted on patch set 7 V +1 07/05/23, 17:16 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/43561

  20. Stefan Bürk voted on patch set 7 V +2 CR +2 07/05/23, 17:34

  21. Stefan Bürk merged patch set 8 07/05/23, 17:34