Review main Merged

77877[TASK] Avoid TYPO3_REQUEST in ext:form FormRuntime

Christian Kuhn CR +2 V +2 Easy +6 −12 updated 02/16/23, 10:08

Commit message

The request is always set to FormRuntime after
creating the object. We can safely avoid the
access to $GLOBALS['TYPO3_REQUEST'] by using
$this->request.

Review

  • Code review CR +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Anja Leichsenring +1
    • Stefan Bürk +1
  • Verified V +2 Done
    • Christian Kuhn +2
    • Oli Bartsch +1
    • Anja Leichsenring +1
    • Stefan Bürk +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Christian Kuhn uploaded patch set 1 02/16/23, 09:01

  2. core-ci voted on patch set 1 V +1 02/16/23, 09:08 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37791

  3. Stefan Bürk voted on patch set 1 V +1 CR +1 02/16/23, 09:24

  4. Oli Bartsch voted on patch set 1 V +1 CR +1 02/16/23, 09:53

  5. Anja Leichsenring voted on patch set 1 V +1 CR +1 02/16/23, 09:54

  6. Christian Kuhn voted on patch set 1 V +2 CR +2 02/16/23, 10:08

  7. Christian Kuhn merged patch set 2 02/16/23, 10:08