Review main Merged

77879[BUGFIX] LiveSearch: Pass correct web mount array into `getFlattenedPages()`

Andreas Kienast CR +2 V +2 Easy +4 −2 updated 02/17/23, 12:44

Commit message

The current search providers accidentally passed a nested array into
`PageRepository->getFlattenedPages()`, leading to issues when resolving
web mounts. This issue is fixed and a new phpstan annotation helps
to avoid this issue in the future.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • Georg Ringer +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 68

  1. Andreas Kienast uploaded patch set 1 02/16/23, 13:04

  2. Andreas Kienast updated the commit message in patch set 2 02/16/23, 13:06

  3. Georg Ringer voted on patch set 2 CR +1 02/16/23, 13:09

  4. core-ci voted on patch set 1 V +1 02/16/23, 13:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37794

  5. core-ci voted on patch set 2 V +1 02/16/23, 13:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37795

  6. Oli Bartsch voted on patch set 2 V +1 CR +1 02/16/23, 13:18

  7. Andreas Kienast voted on patch set 2 V +2 CR +2 02/17/23, 12:44

  8. Andreas Kienast merged patch set 3 02/17/23, 12:44