Review main Merged

77885[FEATURE] Introduce ignoreFlexFormSettingsIfEmpty extbase configuration

Torben Hansen CR +2 V +2 Hard +648 −5 updated 03/20/23, 15:11

Commit message

Extbase extension settings defined in FlexForm always override settings
defined globally in TypoScript. This is a problem for FlexForm fields
which are empty, since an empty value will always override a possible
globally defined TypoScript setting. This behavior might be unwanted
and in case of EXT:felogin, it is currently not possible to define
various settings in TypoScript (e.g. redirect PIDs, storage PID and
more), since they are unintentionally overridden by FlexForm settings.

This patch introduces the new extbase TypoScript configuration
`ignoreFlexFormSettingsIfEmpty`, which allows extbase extensions
to define FlexForm settings, that will be ignored if empty.

Additionally, the new PSR-14 event
`BeforeFlexFormConfigurationOverrideEvent` is available for extension
authors, so a custom FlexForm override process can be implemented.

The new feature is now used in ext:felogin to prevent unwanted
overrides of globally defined TypoScript extension settings.

Review

  • Code review CR +2

    Imported before Forger kept the single votes, the next import adds them.

  • Verified V +2

    Imported before Forger kept the single votes, the next import adds them.

Issues 3

Files 7