77895[BUGFIX] Add correct diff source values to translated record
Commit message
Review
-
Code review CR +2 Done
- Stefan Bürk +2
- Sybille Peters +1
- Nikita Hovratov +1
-
Verified V +2 Done
- Stefan Bürk +2
- Sybille Peters +1
- Nikita Hovratov +1
- core-ci +1 CI
Issues 1
Files 12
- typo3/sysext/core/Classes/DataHandling/DataHandler.php3+9 −5
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/DataSet/TranslationDiffSourceTest.csvnew+4 −0
- typo3/sysext/core/Tests/Functional/DataHandling/DataHandler/TranslationDiffSourceTest.phpnew+82 −0
- typo3/sysext/core/Tests/Functional/DataScenarios/Group/WorkspacesDiscard/DataSet/localizeContentOfRelationWLocalizeReferencesAtParentLocalization.csv+2 −2
- typo3/sysext/core/Tests/Functional/DataScenarios/Group/WorkspacesModify/DataSet/localizeContentOfRelationWLocalizeReferencesAtParentLocalization.csv+2 −2
- typo3/sysext/core/Tests/Functional/DataScenarios/Group/WorkspacesPublish/DataSet/localizeContentOfRelationWLocalizeReferencesAtParentLocalization.csv+2 −2
- typo3/sysext/core/Tests/Functional/DataScenarios/Group/WorkspacesPublishAll/DataSet/localizeContentOfRelationWLocalizeReferencesAtParentLocalization.csv+2 −2
- typo3/sysext/core/Tests/Functional/DataScenarios/Select/Modify/DataSet/localizeContentOfRelationWLocalizeReferencesAtParentLocalization.csv+3 −3
- typo3/sysext/core/Tests/Functional/DataScenarios/Select/WorkspacesDiscard/DataSet/localizeContentOfRelationWLocalizeReferencesAtParentLocalization.csv+2 −2
- typo3/sysext/core/Tests/Functional/DataScenarios/Select/WorkspacesModify/DataSet/localizeContentOfRelationWLocalizeReferencesAtParentLocalization.csv+2 −2
- typo3/sysext/core/Tests/Functional/DataScenarios/Select/WorkspacesPublish/DataSet/localizeContentOfRelationWLocalizeReferencesAtParentLocalization.csv+2 −2
- typo3/sysext/core/Tests/Functional/DataScenarios/Select/WorkspacesPublishAll/DataSet/localizeContentOfRelationWLocalizeReferencesAtParentLocalization.csv+2 −2
Review log 2434
Show 59 earlier messages
-
Markus Hofmann uploaded patch set 1 02/19/23, 10:11
-
core-ci voted on patch set 1 V -1 02/19/23, 10:32 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37867
-
Markus Hofmann uploaded patch set 2
V -102/19/23, 10:38 -
core-ci voted on patch set 2 V -1 02/19/23, 10:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37869
-
Markus Hofmann uploaded patch set 3 02/19/23, 14:05
Copied Votes: * Verified-1 (copy condition: "changekind:NO_CHANGE") -
Markus Hofmann uploaded patch set 4
V -102/19/23, 14:15 -
core-ci voted on patch set 3 V -1 02/19/23, 14:22 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37879
-
core-ci voted on patch set 4 V +1 02/19/23, 14:22 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37880
-
Stefan Bürk commented on patch set 4 CR -1 02/21/23, 18:11
on it ...
-
Stefan Bürk uploaded patch set 5
CR -1V +102/23/23, 08:00 -
core-ci voted on patch set 5 V +1 02/23/23, 08:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37994
-
Stefan Bürk voted on patch set 5 V +1 CR +1 02/23/23, 08:08
-
Stefan Bürk updated the commit message in patch set 6
CR +1V +102/23/23, 09:22 -
Stefan Bürk voted on patch set 6 V +1 CR +1 02/23/23, 09:22
-
core-ci voted on patch set 6 V +1 02/23/23, 09:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37995
-
Nikita Hovratov uploaded patch set 7
CR +1V +102/24/23, 20:13 -
core-ci voted on patch set 7 V +1 02/24/23, 20:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38069
-
Nikita Hovratov voted on patch set 7 V +1 CR +1 02/24/23, 20:34
-
Sybille Peters commented on patch set 7 02/25/23, 08:54
I left some comments on commit msg. Will review and test next. I am a bit nitpicky about text. Don't worry about it. These are mere suggestions (can be accepted or rejected), will not leave -1 for this. Fun fact: I translated entire commit message with DeepL. (I did not do this initially and did not use the result, except for the title, but the DeepL translation is quite good). Translate original commit msg to DE, then press the <-- ---> (Swap source language with target language)> Ensure that diffSource values of translation is directly added My suggestion: "Add DiffSource values to translated record on creation" Reason: this emphasizes that the problem occurs when a new record is created. DeepL suggestion: "Ensure that diffSource values are added directly to the translation." This reads a little more smoothly than original title. Unfortunately it is longer, so I discarded it.Would probably use transOrigDiffSourceField (by convention usually l10n_diffsource) somewhere in the commit message to make it clear what field we are talking about.suggestion: remove "basically" and "eventually" (it seems to me, is not strictly necessary and does not improve readability).This part is difficult to read and understand for me, especially "eventually with a prefix and setting needed system fields" and "localizable fields value" (the value of localizable fields or what is meant here?)> "This has been undiscovered most likely" suggestion: "This probably went undetected because" (is shorter, also if using "undiscovered" should probably be "had remained undiscovered")> and no one is expecting that the value of the source language record changed in the meantime. would remove that entire partMaybe lead with this (start the commit msg with this). Because of long commit msg we might want to lead with short summary what the patch does.Instead of "is used directly" maybe write "is used as soon as a new localized language record is created". The problem is when the new record is created, not when an existing one is opened. The "directly" does not make that clear for me, also "initially" might be better. -
Sybille Peters updated the commit message in patch set 8
CR +1V +102/25/23, 09:40 -
Sybille Peters commented on patch set 8 02/25/23, 09:42
Reply
DoneReply
DoneReply
DoneReply
DoneReply
DoneReply
DoneReply
DoneReply
Done -
Sybille Peters updated the commit message in patch set 9 02/25/23, 09:43
-
core-ci voted on patch set 8 V +1 02/25/23, 09:49 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38080
-
core-ci voted on patch set 9 V +1 02/25/23, 09:50 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38081
-
Sybille Peters commented on patch set 9 02/25/23, 10:25
DataHandler.php:1331This field will also be filled if a new record was created in the default language (sys_language_uid=0) with no corresponding source language record (l10n_parent = 0). Is it really necessary to fill it in that case or should it just be an empty string? (apart from that, patch works as expected +1). -
Sybille Peters voted on patch set 9 CR -1 02/25/23, 11:41
-
Stefan Bürk uploaded patch set 10
CR -1V +102/25/23, 11:46 -
core-ci voted on patch set 10 V +1 02/25/23, 11:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38085
-
Stefan Bürk commented on patch set 10 02/25/23, 11:57
DataHandler.php:1331ReplyShould be covered now. -
Sybille Peters commented on patch set 10 V +1 CR +1 02/25/23, 12:03
😊 -
Nikita Hovratov voted on patch set 10 V +1 CR +1 02/25/23, 12:06
-
Stefan Bürk commented on patch set 10 02/25/23, 12:14
DataHandler.php:1331ReplyDone -
Stefan Bürk voted on patch set 10 V +2 CR +2 02/25/23, 12:15
-
Stefan Bürk merged patch set 11 02/25/23, 12:15