Review 11.5 Merged

77904[BUGFIX] Fix PHP 8 warning in TypoScriptFrontendController

Thomas Hohn CR +2 V +2 Easy +1 −1 updated 02/27/23, 19:29

Commit message

Added null coalescing operator, when value of $this->page['uid']
is accessed in resolveTranslatedPageId. This can occur if the
default language record is hidden.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1620

  1. Thomas Hohn uploaded patch set 1 02/20/23, 14:56

  2. Thomas Hohn updated the commit message in patch set 2 02/20/23, 14:57

  3. core-ci voted on patch set 2 V +1 02/20/23, 15:07 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37900

  4. core-ci voted on patch set 1 V +1 02/20/23, 15:35 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37899

  5. Oliver Klee commented on patch set 2 02/24/23, 17:29

    Is main not affected?
  6. Thomas Hohn commented on patch set 2 02/24/23, 17:34

    Reply

    Hi - no - it has been completely rewritten in main
  7. Oliver Klee voted on patch set 2 CR +1 02/24/23, 17:42

  8. Stefan Bürk updated the commit message in patch set 3 CR +1 V +1 02/24/23, 22:39

  9. Stefan Bürk voted on patch set 3 V +1 CR +1 02/24/23, 22:44

  10. core-ci voted on patch set 3 V +1 02/24/23, 22:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38072

  11. Guido Schmechel voted on patch set 3 CR +1 02/25/23, 13:36

  12. Oliver Klee voted on patch set 3 CR +1 02/26/23, 21:27

  13. Oli Bartsch commented on patch set 3 02/27/23, 11:24

    TypoScriptFrontendController.php:1267

    According to the class properties @var annotation, should we fallback to int or string (preferentially "int")?
  14. Thomas Hohn commented on patch set 3 02/27/23, 11:32

    TypoScriptFrontendController.php:1267 Reply

    Yes would propably be better just to return 0 then
  15. Thomas Hohn uploaded patch set 4 CR +1 V +1 02/27/23, 11:55

  16. Thomas Hohn commented on patch set 4 02/27/23, 11:55

    TypoScriptFrontendController.php:1267 Reply

    Done
  17. core-ci voted on patch set 4 V +1 02/27/23, 12:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/38153

  18. Christian Kuhn voted on patch set 4 V +1 CR +1 02/27/23, 13:57

  19. Stefan Bürk voted on patch set 4 V +2 CR +2 02/27/23, 19:29

  20. Stefan Bürk merged patch set 5 02/27/23, 19:29