Review main Work in progress Orphaned

77905[FEATURE] Support disabling of flexform section fields with PageTS

Justus Moroni CR 0 V 0 Hard +308 −2 updated 04/12/25, 12:38

Commit message

It is currently not possible to disable fields of the nested
array sections inside flexforms.

As it is not possible to have more than one section nested we don't
need to recursively check if fields are supposed to be disabled.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 10
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/05/77905/10 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/05/77905/10 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Issues 1

Files 3

Review log 1626

Show 1 earlier messages
  1. Justus Moroni uploaded patch set 1 02/20/23, 18:04

  1. core-ci voted on patch set 1 V +1 02/20/23, 18:11 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37905

  2. Andreas Kienast marked it ready for review 10/18/23, 08:20

  3. Andreas Kienast commented on patch set 1 CR -1 10/18/23, 08:28

    The patch misses a feature ReST file. You can create one at https://forger.typo3.com/utilities/rst.
  4. Daniel Siepmann uploaded patch set 2 CR -1 V +1 10/18/23, 08:42

  5. Daniel Siepmann uploaded patch set 3 10/18/23, 08:44

  6. core-ci voted on patch set 2 V -1 10/18/23, 08:52 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47895

  7. core-ci voted on patch set 3 V -1 10/18/23, 08:54 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47896

  8. Daniel Siepmann uploaded patch set 4 V -1 10/18/23, 09:00

  9. core-ci voted on patch set 4 V -1 10/18/23, 09:07 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47898

  10. Daniel Siepmann uploaded patch set 5 V -1 10/18/23, 09:20

  11. core-ci voted on patch set 5 V +1 10/18/23, 09:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/47899

  12. Garvin Hicking commented on patch set 5 10/19/23, 11:27

    Feature-99997-SupportDisablingOfFlexFormFieldsWithinRepeatableSectionsViaPageTSconfigTCEFORM.rst:14 Unresolved

    For a better understanding, maybe an exemplary FlexForm XML showing such a structure could be added here? Also escape "type inline" as "type :typoscript:`inline`" here? (Alternatively, maybe a link to the FlexForm documentation dealing with this section feature could help for someone like me, who might not properly get what the feature is about? 😋 )
  13. Benni Mack uploaded patch set 6 V +1 01/21/25, 15:29

  14. core-ci voted on patch set 6 V +1 01/21/25, 15:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/72793

  15. Benni Mack rebased onto patch set 7 V +1 03/26/25, 09:35

  16. core-ci voted on patch set 7 V -1 03/26/25, 09:50 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76365

  17. Benni Mack uploaded patch set 8 V -1 03/27/25, 16:15

  18. Benni Mack commented on patch set 8 03/27/25, 16:15

    TcaFlexProcess.php:233 Unresolved

    we might need to backport this to v13... dunno
  19. core-ci voted on patch set 8 V +1 03/27/25, 16:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/76480

  20. Stefan Bürk commented on patch set 8 04/12/25, 12:24

    Unresolved

    Setting this change to WIP now, as testing this revealed outstanding issues/side-effects. Current state (changeset 8) crashes in some scenarios. On the one side, these are technical issues and on the other hand the `user experience` needs to be investigated and how to deal with these. Or better to say, define how it should work for the user and what user expects and can expect. With the current state, following issue rises up: * The `add section` button for a complete disabled (and removed) section is not removed from the listing below the section field. Clicking sends a AJAX calls which returns a exception (debug mode) and is not working related to retrieve labels. * If all fields of a section is disabled and therefore removed, leaving a empty section the same ajax error occurs and new elements are not creatable. Beside the technical issue a empty section should be removed all together, which may be doable in the current change as a second loop after the first removing loop. Leading to the kept inoperable `add button` mentioned in the point above. * Assumend that the issues with the ajax call and the `add button` are handled, the next point is what should happen with already selected/added items of the disabled (removed) section type. Currently, they are also not displayed and are not removed when persisting the record. That is good and bad, depending on the point of view. Good, because they are not lost. For others bad as they cannot be removed and still used/handled/displayed in the frontend (assuming they are used to render stuff) leading to a confusion for editors which can't find the output in the record. I tested this with styleguide on the `styleguide tca demo` -> `flex` form page by using following PageTsConfig directly on that page (commenting/commenting out lines to test different things). Browser development tools needs to be open to see the failing ajax requests / stack trackes (in debug mode): ``` //TCEFORM.tx_styleguide_flex.flex_2.default.sSection.section_1.disabled = 1 //TCEFORM.tx_styleguide_flex.flex_2.default.sSection.section_1.container_1.disabled = 1 //TCEFORM.tx_styleguide_flex.flex_2.default.sSection.section_1.container_2.text_1.disabled = 1 //TCEFORM.tx_styleguide_flex.flex_2.default.sSection.section_1.container_1.input_1.disabled = 1 ``` No quick finishing here possible here, but should be doable with some additional work and thinking about the user => set to WIP again.
  21. Stefan Bürk updated the commit message in patch set 9 V +1 04/12/25, 12:25

  22. Stefan Bürk marked it work in progress 04/12/25, 12:25

  23. Stefan Bürk updated the commit message in patch set 10 04/12/25, 12:25

  24. core-ci voted on patch set 9 V +1 04/12/25, 12:34 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77616

  25. core-ci voted on patch set 10 V +1 04/12/25, 12:38 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/77618