Review 11.5 Abandoned

77906[BUGFIX] Fix PHP 8 warning in PageRepository

Thomas Hohn CR 0 V 0 Easy +2 −2 updated 02/20/23, 20:50

Commit message

Added Null coalescing operator, when value of $row['uid'] and
$row['pid'] is accessed in getRecordOverlay to avoid PHP
warning.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 56

  1. Thomas Hohn uploaded patch set 1 02/20/23, 18:19

  2. core-ci voted on patch set 1 V +1 02/20/23, 18:27 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37907

  3. Oliver Klee voted on patch set 1 CR +1 02/20/23, 20:15

  4. Oli Bartsch commented on patch set 1 V -1 02/20/23, 20:39

    Please create a patch for main first.
  5. Thomas Hohn commented on patch set 1 02/20/23, 20:49

    Reply

    Will do
  6. Thomas Hohn abandoned the change 02/20/23, 20:50

    Should be solved in main first