Review main Merged

77907[BUGFIX] Fix PHP 8 warning in PageRepository

Thomas Hohn CR +2 V +2 Easy +2 −2 updated 02/27/23, 19:44

Commit message

Added Null coalescing operator, when value of $row['uid'] and
$row['pid'] is accessed in getRecordOverlay to avoid PHP
warning.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2 Done
    • Stefan Bürk +2
    • Oli Bartsch +1
    • Christian Kuhn +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 89

  1. Thomas Hohn uploaded patch set 1 02/20/23, 20:52

  2. core-ci voted on patch set 1 V +1 02/20/23, 20:59 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/37908

  3. Oli Bartsch voted on patch set 1 V +1 CR +1 02/20/23, 21:01

  4. Oliver Klee voted on patch set 1 CR +1 02/20/23, 21:03

  5. Benni Mack commented on patch set 1 02/21/23, 15:59

    How does this occur? I mean, getRecordOverlay should not be called from the outside anymore and then the full row should be handed in?
  6. Thomas Hohn commented on patch set 1 02/21/23, 16:11

    Reply

    Hi Method is public in 11,X - asked the creator of the bug report to come up on how it can/could be reproduced
  7. Christian Kuhn commented on patch set 1 V +1 CR +1 02/27/23, 14:24

    Reply

    I'd say we should sanitize this as proposed, even though $row should always contain uid and pid.
  8. Stefan Bürk commented on patch set 1 V +2 CR +2 02/27/23, 19:43

    Reply

    I'd say it does not hurt for v12 albit the method is now protected. It add's a small safetiy layer here. And it's in place, therefore for the backport having it the same for now is ok.
  9. Stefan Bürk merged patch set 2 02/27/23, 19:44